Ladsgroup has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402798 )
Change subject: Reorder attributes in ThresholdLookup
......................................................................
Reorder attributes in ThresholdLookup
The way it's determined is confusing, see I60859e8ad for more discussion
Bug: T181892
Change-Id: Id0aaaf88d233e1b09a8d50d8ed8277cfdae3cdac
---
M includes/ThresholdLookup.php
1 file changed, 20 insertions(+), 20 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ORES
refs/changes/98/402798/1
diff --git a/includes/ThresholdLookup.php b/includes/ThresholdLookup.php
index ba69340..b91b2b5 100644
--- a/includes/ThresholdLookup.php
+++ b/includes/ThresholdLookup.php
@@ -16,13 +16,23 @@
namespace ORES;
-use Liuggio\StatsdClient\Factory\StatsdDataFactoryInterface;
+use IBufferingStatsdDataFactory;
use ORES\Storage\ModelLookup;
use Psr\Log\LoggerInterface;
use RuntimeException;
use WANObjectCache;
class ThresholdLookup {
+
+ /**
+ * @var ThresholdParser
+ */
+ private $thresholdParser;
+
+ /**
+ * @var ModelLookup
+ */
+ private $modelLookup;
/**
* @var ORESService
@@ -40,41 +50,31 @@
private $logger;
/**
- * @var ModelLookup
- */
- private $modelLookup;
-
- /**
- * @var ThresholdParser
- */
- private $thresholdParser;
-
- /**
- * @var StatsdDataFactoryInterface
+ * @var IBufferingStatsdDataFactory
*/
private $statsdDataFactory;
/**
+ * @param ThresholdParser $thresholdParser
+ * @param ModelLookup $modelLookup
* @param ORESService $oresService
* @param WANObjectCache $cache
* @param LoggerInterface $logger
- * @param ModelLookup $modelLookup
- * @param ThresholdParser $thresholdParser
- * @param StatsdDataFactoryInterface $statsdDataFactory
+ * @param IBufferingStatsdDataFactory $statsdDataFactory
*/
public function __construct(
+ ThresholdParser $thresholdParser,
+ ModelLookup $modelLookup,
ORESService $oresService,
WANObjectCache $cache,
LoggerInterface $logger,
- ModelLookup $modelLookup,
- ThresholdParser $thresholdParser,
- StatsdDataFactoryInterface $statsdDataFactory
+ IBufferingStatsdDataFactory $statsdDataFactory
) {
+ $this->thresholdParser = $thresholdParser;
+ $this->modelLookup = $modelLookup;
$this->oresService = $oresService;
$this->cache = $cache;
$this->logger = $logger;
- $this->modelLookup = $modelLookup;
- $this->thresholdParser = $thresholdParser;
$this->statsdDataFactory = $statsdDataFactory;
}
--
To view, visit https://gerrit.wikimedia.org/r/402798
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0aaaf88d233e1b09a8d50d8ed8277cfdae3cdac
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
