Esanders has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402842 )
Change subject: MWImageModel: Check selectedNode exists before asking for
property
......................................................................
MWImageModel: Check selectedNode exists before asking for property
Bug: T180521
Change-Id: I1c10929abd6f5c4afa03a65904bc76fc82f8fcbb
---
M modules/ve-mw/dm/models/ve.dm.MWImageModel.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/42/402842/1
diff --git a/modules/ve-mw/dm/models/ve.dm.MWImageModel.js
b/modules/ve-mw/dm/models/ve.dm.MWImageModel.js
index 600705a..8b727b9 100644
--- a/modules/ve-mw/dm/models/ve.dm.MWImageModel.js
+++ b/modules/ve-mw/dm/models/ve.dm.MWImageModel.js
@@ -458,7 +458,7 @@
switch ( nodeType ) {
case 'mwInlineImage':
- if ( selectedNode.type === 'mwBlockImage' ) {
+ if ( selectedNode && selectedNode.type ===
'mwBlockImage' ) {
// If converting from a block image, create a
wrapper paragraph for the inline image to go in.
fragment.insertContent( [ { type: 'paragraph',
internal: { generated: 'wrapper' } }, { type: '/paragraph' } ] );
offset =
fragment.getSelection().getRange().start + 1;
--
To view, visit https://gerrit.wikimedia.org/r/402842
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c10929abd6f5c4afa03a65904bc76fc82f8fcbb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
