Brion VIBBER has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402935 )
Change subject: Regression fix for TMH + Score integration
......................................................................
Regression fix for TMH + Score integration
If there wasn't another TMH invocation on the page, the audio player
generated by a <score vorbis=1>...</score> would not invoke the TMH
frontend, resulting in inconsistent appearance and failure to run
the Ogg output on Safari/IE/Edge.
This was due to changes in the frontend code for TMH a while back;
added a workaround to invoke the TMH-side code that sets it up, but
not sure this is nice. :D
Still want a better interface between these two for the future.
Bug: T148716
Change-Id: I0b86d37ac268a45dd3417fc7cbb49f3f7d3adbee
---
M includes/Score.php
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Score
refs/changes/35/402935/1
diff --git a/includes/Score.php b/includes/Score.php
index b7a2583..d9b2ac8 100644
--- a/includes/Score.php
+++ b/includes/Score.php
@@ -511,6 +511,14 @@
'width' => self::DEFAULT_PLAYER_WIDTH
] );
$link .= $player->toHtml();
+
+ // This is a hack for T148716 to load the TMH
frontend
+ // which we're sort of side-using here. In the
future,
+ // we should use a clean standard interface for
this.
+ $tmh = new TimedMediaHandler();
+ if ( method_exists( $tmh, 'parserTransformHook'
) ) {
+ $tmh->parserTransformHook( $parser,
null );
+ }
}
if ( $options['override_audio'] !== false ) {
$link .= $parser->recursiveTagParse(
"[[File:{$options['audio_name']}]]" );
--
To view, visit https://gerrit.wikimedia.org/r/402935
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b86d37ac268a45dd3417fc7cbb49f3f7d3adbee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Score
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <br...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
