jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/402126 )
Change subject: Feature flag Wikidata Descriptions
......................................................................
Feature flag Wikidata Descriptions
Wikidata descriptions are not protected by a feature flag and still
use the isBetaGroupMember logic. To allow us to list all features in
beta we'll want to make this configurable like all the others.
Bug: T182362
Change-Id: Ic17435b5a5594690f6930e16b0cf79cd65e4bbb0
---
M README.md
M extension.json
M includes/MobileContext.php
3 files changed, 19 insertions(+), 1 deletion(-)
Approvals:
Pmiazga: Looks good to me, approved
jenkins-bot: Verified
Jdlrobson: Looks good to me, approved
diff --git a/README.md b/README.md
index c3a3a6c..6c3625c 100644
--- a/README.md
+++ b/README.md
@@ -574,6 +574,20 @@
* Type: `Boolean`
* Default: `false`
+#### $wgMFEnableWikidataDescriptions
+
+If set to true, wikidata descriptions as defined in
$wgMFDisplayWikibaseDescriptions will show up
+in the UI in the environment they have been told to target.
+
+* Type: `Array`
+* Default:
+```php
+ [
+ 'beta' => true,
+ 'base' => false,
+ ]
+```
+
#### $wgMFDisplayWikibaseDescriptions
Set which features will use Wikibase descriptions, e.g.
diff --git a/extension.json b/extension.json
index 91b2d8f..d0f5318 100644
--- a/extension.json
+++ b/extension.json
@@ -1315,6 +1315,10 @@
"beta": true
},
"MFUseWikibase": false,
+ "MFEnableWikidataDescriptions": {
+ "base": false,
+ "beta": true
+ },
"MFDisplayWikibaseDescriptions": {
"search": false,
"nearby": false,
diff --git a/includes/MobileContext.php b/includes/MobileContext.php
index a788387..1da8860 100644
--- a/includes/MobileContext.php
+++ b/includes/MobileContext.php
@@ -1167,7 +1167,7 @@
}
if (
- $this->isBetaGroupMember() ||
+ $this->getConfigVariable(
'MFEnableWikidataDescriptions' ) ||
( $config->get( 'MFUseWikibase' ) &&
$displayWikibaseDescriptions[ $feature ] )
) {
return true;
--
To view, visit https://gerrit.wikimedia.org/r/402126
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic17435b5a5594690f6930e16b0cf79cd65e4bbb0
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: specialpages
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Pmiazga <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
