Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/57896
Change subject: Zuul status page: Fix reference error that crashes/freezes the
page
......................................................................
Zuul status page: Fix reference error that crashes/freezes the page
* Property data.trigger_event_queue and data.trigger_event_queue
can be undefined, in which case data.trigger_event_queue.length
causes an uncaught TypeError to be thrown.
Change-Id: I7cf6799869c6fdd9765062737114984f38bfb12d
---
M org/wikimedia/integration/zuul/status.js
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/integration/docroot
refs/changes/96/57896/1
diff --git a/org/wikimedia/integration/zuul/status.js
b/org/wikimedia/integration/zuul/status.js
index e7f6b68..e994a2a 100644
--- a/org/wikimedia/integration/zuul/status.js
+++ b/org/wikimedia/integration/zuul/status.js
@@ -129,6 +129,7 @@
function update() {
$.getJSON('/zuul/status.json', function(data) {
+ data = data || {};
var html = '';
if ('message' in data) {
$('#message')
@@ -150,10 +151,10 @@
$('#pipeline-container').html(html);
$('#trigger_event_queue_length').text(
- data.trigger_event_queue.length
+ ( data.trigger_event_queue || [] ).length
);
$('#result_event_queue_length').text(
- data.result_event_queue.length
+ ( data.result_event_queue || [] ).length
);
});
--
To view, visit https://gerrit.wikimedia.org/r/57896
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7cf6799869c6fdd9765062737114984f38bfb12d
Gerrit-PatchSet: 1
Gerrit-Project: integration/docroot
Gerrit-Branch: master
Gerrit-Owner: Krinkle <ttij...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
