Albert221 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403066 )
Change subject: Remove redundant HTML element in favor of CSS
......................................................................
Remove redundant HTML element in favor of CSS
Bug: T183672
Change-Id: I1f8a8413a5f4da441e3f4b4ef0b1e03d174987ca
---
M includes/EditPage.php
M resources/src/mediawiki.action/mediawiki.action.edit.styles.less
2 files changed, 5 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/66/403066/1
diff --git a/includes/EditPage.php b/includes/EditPage.php
index 3c109f6..a8be3aa 100644
--- a/includes/EditPage.php
+++ b/includes/EditPage.php
@@ -3670,11 +3670,6 @@
$out->addHTML( implode( $this->getEditButtons( $tabindex ),
"\n" ) . "\n" );
$cancel = $this->getCancelLink();
- if ( $cancel !== '' ) {
- $cancel .= Html::element( 'span',
- [ 'class' => 'mw-editButtons-pipe-separator' ],
- $this->context->msg( 'pipe-separator' )->text()
);
- }
$message = $this->context->msg( 'edithelppage'
)->inContentLanguage()->text();
$edithelpurl = Skin::makeInternalOrExternalUrl( $message );
diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.styles.less
b/resources/src/mediawiki.action/mediawiki.action.edit.styles.less
index e4443f6..aeaed7b 100644
--- a/resources/src/mediawiki.action/mediawiki.action.edit.styles.less
+++ b/resources/src/mediawiki.action/mediawiki.action.edit.styles.less
@@ -46,9 +46,13 @@
}
.editHelp {
- margin-left: 0.5em;
vertical-align: middle;
+ &:before {
+ content: '|';
+ margin-right: 0.5em;
+ }
+
a {
font-weight: bold;
}
--
To view, visit https://gerrit.wikimedia.org/r/403066
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f8a8413a5f4da441e3f4b4ef0b1e03d174987ca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Albert221 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
