jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/402849 )
Change subject: Fix bad type hints for ApiErrorReporter
......................................................................
Fix bad type hints for ApiErrorReporter
As reported by Phan.
Luckily this mistake did not have any consequences.
Change-Id: Ie133bb642681e56d9105eca536c1f17aaf750004
---
M repo/includes/Api/RemoveQualifiers.php
M repo/includes/Api/SetClaimValue.php
M repo/includes/Api/StatementModificationHelper.php
3 files changed, 7 insertions(+), 9 deletions(-)
Approvals:
Ladsgroup: Looks good to me, approved
Lucas Werkmeister (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/includes/Api/RemoveQualifiers.php
b/repo/includes/Api/RemoveQualifiers.php
index 911cce1..bf1d001 100644
--- a/repo/includes/Api/RemoveQualifiers.php
+++ b/repo/includes/Api/RemoveQualifiers.php
@@ -54,7 +54,7 @@
/**
* @param ApiMain $mainModule
* @param string $moduleName
- * @param string $errorReporter
+ * @param ApiErrorReporter $errorReporter
* @param StatementChangeOpFactory $statementChangeOpFactory
* @param StatementModificationHelper $modificationHelper
* @param StatementGuidParser $guidParser
@@ -64,7 +64,7 @@
public function __construct(
ApiMain $mainModule,
$moduleName,
- $errorReporter,
+ ApiErrorReporter $errorReporter,
StatementChangeOpFactory $statementChangeOpFactory,
StatementModificationHelper $modificationHelper,
StatementGuidParser $guidParser,
diff --git a/repo/includes/Api/SetClaimValue.php
b/repo/includes/Api/SetClaimValue.php
index ed76bab..6246dbf 100644
--- a/repo/includes/Api/SetClaimValue.php
+++ b/repo/includes/Api/SetClaimValue.php
@@ -49,7 +49,7 @@
/**
* @param ApiMain $mainModule
* @param string $moduleName
- * @param string $errorReporter
+ * @param ApiErrorReporter $errorReporter
* @param StatementChangeOpFactory $statementChangeOpFactory
* @param StatementModificationHelper $modificationHelper
* @param StatementGuidParser $guidParser
@@ -59,7 +59,7 @@
public function __construct(
ApiMain $mainModule,
$moduleName,
- $errorReporter,
+ ApiErrorReporter $errorReporter,
StatementChangeOpFactory $statementChangeOpFactory,
StatementModificationHelper $modificationHelper,
StatementGuidParser $guidParser,
@@ -67,6 +67,7 @@
callable $entitySavingHelperInstantiator
) {
parent::__construct( $mainModule, $moduleName );
+
$this->errorReporter = $errorReporter;
$this->statementChangeOpFactory = $statementChangeOpFactory;
$this->modificationHelper = $modificationHelper;
diff --git a/repo/includes/Api/StatementModificationHelper.php
b/repo/includes/Api/StatementModificationHelper.php
index 78c729c..992a6b0 100644
--- a/repo/includes/Api/StatementModificationHelper.php
+++ b/repo/includes/Api/StatementModificationHelper.php
@@ -47,12 +47,9 @@
/**
* @var ApiErrorReporter
- *
- * @param SnakFactory $snakFactory
- * @param EntityIdParser $entityIdParser
- * @param StatementGuidValidator $guidValidator
- * @param ApiErrorReporter $errorReporter
*/
+ private $errorReporter;
+
public function __construct(
SnakFactory $snakFactory,
EntityIdParser $entityIdParser,
--
To view, visit https://gerrit.wikimedia.org/r/402849
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie133bb642681e56d9105eca536c1f17aaf750004
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Kreuz (WMDE) <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Kreuz (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
