Yaron Koren has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403551 )
Change subject: Fix for 2270fb67891f - removed unset() call ...................................................................... Fix for 2270fb67891f - removed unset() call It led to an error in certain cases - see https://phabricator.wikimedia.org/T181903 Change-Id: Ia2c07fca66edfb07c2d1ca58394fd07c0f9c766f --- M includes/SpecialContributors.php 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Contributors refs/changes/51/403551/2 diff --git a/includes/SpecialContributors.php b/includes/SpecialContributors.php index f847ee7..6c06c32 100644 --- a/includes/SpecialContributors.php +++ b/includes/SpecialContributors.php @@ -32,10 +32,8 @@ $this->setHeaders(); $opts = $this->getOptions(); - $target = $opts['target']; - unset( $opts['target'] ); $this->setContributorsClass( - new Contributors( Title::newFromText( $target ), $opts->getAllValues() ) ); + new Contributors( Title::newFromText( $opts['target'] ), $opts->getAllValues() ) ); # What are we doing? Different execution paths for inclusion, # direct access and raw access -- To view, visit https://gerrit.wikimedia.org/r/403551 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia2c07fca66edfb07c2d1ca58394fd07c0f9c766f Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Contributors Gerrit-Branch: master Gerrit-Owner: Yaron Koren <yaro...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
