Cooltey has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403573 )
Change subject: Hygiene: Remove unused methods and class
......................................................................
Hygiene: Remove unused methods and class
Change-Id: I08b4df08627d3894cfbb5de905b7048ac93b346e
---
M app/src/main/java/org/wikipedia/util/DimenUtil.java
M app/src/main/java/org/wikipedia/util/L10nUtil.java
M app/src/main/java/org/wikipedia/util/ThrowableUtil.java
D app/src/main/java/org/wikipedia/util/ValidateUtil.java
4 files changed, 4 insertions(+), 22 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/73/403573/1
diff --git a/app/src/main/java/org/wikipedia/util/DimenUtil.java
b/app/src/main/java/org/wikipedia/util/DimenUtil.java
index 815d44f..4e93b68 100644
--- a/app/src/main/java/org/wikipedia/util/DimenUtil.java
+++ b/app/src/main/java/org/wikipedia/util/DimenUtil.java
@@ -131,14 +131,6 @@
return (int) (getDisplayHeightPx() *
articleHeaderViewScreenHeightRatio());
}
- public static int newsFeatureImageHeightForDevice() {
- return (int) (getDisplayHeightPx() *
newsFeatureImageScreenHeightRatio());
- }
-
- private static float newsFeatureImageScreenHeightRatio() {
- return DimenUtil.getFloat(R.dimen.newsFeatureImageScreenHeightRatio);
- }
-
private static float articleHeaderViewScreenHeightRatio() {
return DimenUtil.getFloat(R.dimen.articleHeaderViewScreenHeightRatio);
}
diff --git a/app/src/main/java/org/wikipedia/util/L10nUtil.java
b/app/src/main/java/org/wikipedia/util/L10nUtil.java
index a4b015b..48baf4c 100644
--- a/app/src/main/java/org/wikipedia/util/L10nUtil.java
+++ b/app/src/main/java/org/wikipedia/util/L10nUtil.java
@@ -225,6 +225,7 @@
}
}
+ // TODO: remove this if we can get correct language counts from server
public static int getUpdatedLanguageCountIfNeeded(String getLanguageCode,
int originalLanguageCount) {
int updatedLanguageCount = originalLanguageCount;
diff --git a/app/src/main/java/org/wikipedia/util/ThrowableUtil.java
b/app/src/main/java/org/wikipedia/util/ThrowableUtil.java
index e78cb01..4c6d6b6 100644
--- a/app/src/main/java/org/wikipedia/util/ThrowableUtil.java
+++ b/app/src/main/java/org/wikipedia/util/ThrowableUtil.java
@@ -22,7 +22,7 @@
// TODO: replace with Apache Commons Lang ExceptionUtils.
@NonNull
- public static Throwable getInnermostThrowable(@NonNull Throwable e) {
+ private static Throwable getInnermostThrowable(@NonNull Throwable e) {
Throwable t = e;
while (t.getCause() != null) {
t = t.getCause();
@@ -31,7 +31,7 @@
}
// TODO: replace with Apache Commons Lang ExceptionUtils.
- public static boolean throwableContainsException(@NonNull Throwable e,
Class<?> exClass) {
+ private static boolean throwableContainsException(@NonNull Throwable e,
Class<?> exClass) {
Throwable t = e;
while (t != null) {
if (t.getClass().equals(exClass)) {
@@ -96,7 +96,7 @@
@Deprecated public static class AppError {
private String error;
private String detail;
- public AppError(@NonNull String error, @Nullable String detail) {
+ private AppError(@NonNull String error, @Nullable String detail) {
this.error = error;
this.detail = detail;
}
diff --git a/app/src/main/java/org/wikipedia/util/ValidateUtil.java
b/app/src/main/java/org/wikipedia/util/ValidateUtil.java
deleted file mode 100644
index d00271e..0000000
--- a/app/src/main/java/org/wikipedia/util/ValidateUtil.java
+++ /dev/null
@@ -1,11 +0,0 @@
-package org.wikipedia.util;
-
-import org.apache.commons.lang3.Validate;
-
-public final class ValidateUtil {
- public static void noNullElements(Object... objs) {
- Validate.noNullElements(objs);
- }
-
- private ValidateUtil() { }
-}
--
To view, visit https://gerrit.wikimedia.org/r/403573
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I08b4df08627d3894cfbb5de905b7048ac93b346e
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Cooltey <cf...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
