Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 44228) Cloning tooltip content ......................................................................
(bug 44228) Cloning tooltip content When showing a tooltip's bubble, the DOM content needs to be cloned since IE8 will lose the reference to the DOM content when the inner HTML is removed within tipsy's native show() method. Change-Id: I010f7086fec45814c2715667f2d2056fdfd926b0 --- M lib/resources/wikibase.ui.Tooltip.js 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Tobias Gritschacher: Verified; Looks good to me, approved jenkins-bot: Checked diff --git a/lib/resources/wikibase.ui.Tooltip.js b/lib/resources/wikibase.ui.Tooltip.js index cd10267..7a52903 100644 --- a/lib/resources/wikibase.ui.Tooltip.js +++ b/lib/resources/wikibase.ui.Tooltip.js @@ -233,6 +233,11 @@ // showing the tooltip before filling it with content and cache the initial position. // TODO: This is not the most elegant solution since the $tip might reach out of the // viewport. + // The DOM content needs to be cloned since IE8 will lose the reference to the DOM + // content when the inner HTML is removed within tipsy's native show() method. + if ( this._DomContent ) { + this._DomContent = this._DomContent.clone(); + } this._tipsy.show(); var offset = this._tipsy.$tip.offset(), -- To view, visit https://gerrit.wikimedia.org/r/58065 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I010f7086fec45814c2715667f2d2056fdfd926b0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater <henning.sna...@wikimedia.de> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits