Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 44228) Replacing "textContent" with "nodeValue" ......................................................................
(bug 44228) Replacing "textContent" with "nodeValue" Using "textContent" in wb.utilities.ui.buildPrettyEntityLabel is not necessary and incompatible to IE < 9. Change-Id: If04358e66c70e4a4a6f711fdf0fa248cf60d6998 --- M lib/resources/wikibase.utilities/wikibase.utilities.ui.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tobias Gritschacher: Verified; Looks good to me, approved jenkins-bot: Checked diff --git a/lib/resources/wikibase.utilities/wikibase.utilities.ui.js b/lib/resources/wikibase.utilities/wikibase.utilities.ui.js index 46d0f3a..c863a1f 100644 --- a/lib/resources/wikibase.utilities/wikibase.utilities.ui.js +++ b/lib/resources/wikibase.utilities/wikibase.utilities.ui.js @@ -143,7 +143,7 @@ if( !label ) { if( text ) { // empty if entity without ID - $label[0].textContent += SPACE; + $label[0].nodeValue += SPACE; } var $undefinedInfo = $( '<span/>', { 'class': 'wb-entity-undefinedinfo', -- To view, visit https://gerrit.wikimedia.org/r/58067 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If04358e66c70e4a4a6f711fdf0fa248cf60d6998 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater <henning.sna...@wikimedia.de> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits