jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/404241 )
Change subject: Hygiene: add more summary tests
......................................................................
Hygiene: add more summary tests
Change-Id: I245cb3b3715cb67b7c589f42079f34203c25d32d
---
M test/features/summary/pagecontent.js
1 file changed, 17 insertions(+), 6 deletions(-)
Approvals:
jenkins-bot: Verified
Mholloway: Looks good to me, approved
diff --git a/test/features/summary/pagecontent.js
b/test/features/summary/pagecontent.js
index 9d5d999..3ffa217 100644
--- a/test/features/summary/pagecontent.js
+++ b/test/features/summary/pagecontent.js
@@ -57,13 +57,24 @@
});
});
- it('204 should be returned for redirect page', () => {
- const uri = localUri('Barack');
+ function should204(uri) {
return preq.get({ uri })
- .then((res) => {
- assert.deepEqual(res.status, 204);
- assert.ok(!res.body);
- });
+ .then((res) => {
+ assert.deepEqual(res.status, 204);
+ assert.deepEqual(res.body, undefined, 'no content');
+ });
+ }
+
+ it('204 should be returned for a file page', () => {
+ should204(localUri('File:En-Alliterative_verse-article.ogg',
'commons.wikimedia.org'));
+ });
+
+ it('204 should be returned for a talk page', () => {
+ should204(localUri('Talk:Foobar'));
+ });
+
+ it('204 should be returned for a redirected page', () => {
+ should204(localUri('Barack'));
});
it('timestamp should refer to the requested revision, not the latest
revision', () => {
--
To view, visit https://gerrit.wikimedia.org/r/404241
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I245cb3b3715cb67b7c589f42079f34203c25d32d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Fjalapeno <cfl...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: Mhurd <mh...@wikimedia.org>
Gerrit-Reviewer: Ppchelko <ppche...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
