Bartosz Dziewoński has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404396 )
Change subject: OOjs UI: Remove confusing 'position' override
......................................................................
OOjs UI: Remove confusing 'position' override
Vector is the only skin that does this, setting 'position: relative'
for .oo-ui-windowManager-modal (normally 'position: static') and for
.ve-ui-overlay-global (normally 'position: absolute').
The override for .oo-ui-windowManager-modal caused it to create a new
stacking context, which is the only reason the 'z-index' override
worked. Use the right selector to override 'z-index' instead.
The override for .ve-ui-overlay-global was completely pointless and
it's surprising that it never broke anything.
Change-Id: Icd1dec43e2da9ef2090b18145099838de3a7890a
---
M skinStyles/ooui.less
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector
refs/changes/96/404396/1
diff --git a/skinStyles/ooui.less b/skinStyles/ooui.less
index 12123b2..fa03233 100644
--- a/skinStyles/ooui.less
+++ b/skinStyles/ooui.less
@@ -1,9 +1,8 @@
@import '../variables.less';
-.oo-ui-windowManager-modal,
+.skin-vector .oo-ui-windowManager-modal > .oo-ui-dialog,
.skin-vector .ve-ui-overlay-global {
z-index: 101;
- position: relative;
}
.oo-ui-defaultOverlay {
--
To view, visit https://gerrit.wikimedia.org/r/404396
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd1dec43e2da9ef2090b18145099838de3a7890a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
