Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404610 )
Change subject: Test case: Nested spans should be removed... ...................................................................... Test case: Nested spans should be removed... No solution as of yet, but the logic to remove empty nodes is incorrect as rmElementsWithSelector(doc, 'span:empty,b:empty,i:empty,p:empty'); is not recursive. This can be seen on Ariana Grande wiki page - the summary results in a parenthetical with an empty span... Bug: T185050 Change-Id: I56f44e3a3d2825173c293429c73237db05e2a000 --- M test/lib/transformations/summarize.js 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps refs/changes/10/404610/1 diff --git a/test/lib/transformations/summarize.js b/test/lib/transformations/summarize.js index ec25458..7898069 100644 --- a/test/lib/transformations/summarize.js +++ b/test/lib/transformations/summarize.js @@ -8,6 +8,11 @@ describe('summarize', () => { it('matches the spec', () => { const testCases = [ + // Should remove nested empty spans + [ + 'Hello (<span><span><span></span></span><span></span></span>) darkness', + 'Hello darkness' + ], // Should remove unwanted elements [ '.<style>f</style><object>o</object><script>o</script>.', -- To view, visit https://gerrit.wikimedia.org/r/404610 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I56f44e3a3d2825173c293429c73237db05e2a000 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/services/mobileapps Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits