jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/404495 )
Change subject: Drop use of MobileOptionsTracking schema
......................................................................
Drop use of MobileOptionsTracking schema
Going forward we can rely on pageview data to get a sense of how
many users are in beta.
statsd also gives us a little information on behaviour of the form
so we keep it.
EventLogging has been broken for some time so is removed.
Bug: T182235
Change-Id: I365a31a2e4d1cce280d89fc2a2004290e8ff548d
---
M includes/specials/SpecialMobileOptions.php
1 file changed, 1 insertion(+), 22 deletions(-)
Approvals:
jenkins-bot: Verified
Phuedx: Looks good to me, approved
Jdlrobson: Looks good to me, but someone else must approve
diff --git a/includes/specials/SpecialMobileOptions.php
b/includes/specials/SpecialMobileOptions.php
index 81cfdbe..a61e1ce 100644
--- a/includes/specials/SpecialMobileOptions.php
+++ b/includes/specials/SpecialMobileOptions.php
@@ -219,12 +219,6 @@
* of returnto or, if not set, back to this special page
*/
private function submitSettingsForm() {
- $schema = 'MobileOptionsTracking';
- $schemaRevision = 16934032;
- $schemaData = [
- 'action' => 'success',
- 'beta' => "nochange",
- ];
$context = MobileContext::singleton();
$request = $this->getRequest();
$user = $this->getUser();
@@ -236,26 +230,11 @@
. $this->msg( "mobile-frontend-save-error"
)->parse()
. '</div>'
);
- $schemaData['action'] = 'error';
- $schemaData['errorText'] = $errorText;
- ExtMobileFrontend::eventLog( $schema, $schemaRevision,
$schemaData );
$this->addSettingsForm();
return;
}
- if ( $request->getBool( 'enableBeta' ) ) {
- $group = 'beta';
- if ( !$context->isBetaGroupMember() ) {
- // The request was to turn on beta
- $schemaData['beta'] = "on";
- }
- } else {
- $group = '';
- if ( $context->isBetaGroupMember() ) {
- // beta was turned off
- $schemaData['beta'] = "off";
- }
- }
+ $group = $request->getBool( 'enableBeta' ) ? 'beta' : '';
$context->setMobileMode( $group );
$returnToTitle = Title::newFromText( $request->getText(
'returnto' ) );
if ( $returnToTitle ) {
--
To view, visit https://gerrit.wikimedia.org/r/404495
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I365a31a2e4d1cce280d89fc2a2004290e8ff548d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
