Mepps has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/404806 )

Change subject: Add logging for errors
......................................................................

Add logging for errors

Bug: T184284
Change-Id: I4db1828e185d4e723a8d9170a1a2c21ac4e543dd
---
M sites/all/modules/orphan_slayer/orphan_slayer.module
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm 
refs/changes/06/404806/1

diff --git a/sites/all/modules/orphan_slayer/orphan_slayer.module 
b/sites/all/modules/orphan_slayer/orphan_slayer.module
index 0a13435..b21cd26 100644
--- a/sites/all/modules/orphan_slayer/orphan_slayer.module
+++ b/sites/all/modules/orphan_slayer/orphan_slayer.module
@@ -9,7 +9,12 @@
     while ($orphan && ($orphan['date'] < UtcDate::getUtcTimestamp("-$time 
minutes"))) {
         if ($orphan['contribution_tracking_id']) {
             $result = $slayer->rectify($orphan);
-            watchdog('orphan slayer', 'orphan ' 
.$orphan['contribution_tracking_id'] . ': was rectified and the result is ' . 
print_r($result, true));
+            if ( count( $result->getErrors() ) > 0 ) {
+                watchdog('orphan slayer', 'orphan ' 
.$orphan['contribution_tracking_id'] . ': encountered an error ' . 
print_r($result->getErrors(), true));
+            }
+            else {
+                watchdog('orphan slayer', 'orphan ' . 
$orphan['contribution_tracking_id'] . ': was rectified and the result is ' . 
print_r($result, true));
+            }
         } else {
             $slayer->cancel($orphan);
         }

-- 
To view, visit https://gerrit.wikimedia.org/r/404806
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4db1828e185d4e723a8d9170a1a2c21ac4e543dd
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Mepps <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to