jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403683 )
Change subject: Update: missing preview copy
......................................................................
Update: missing preview copy
Update the placeholder extract and button text shown when a page preview
is unavailable from:
"popups-preview-no-preview": "Looks like there isn't a preview for this page"
"popups-preview-footer-read": "Read"
To:
"popups-preview-no-preview": "There was an issue displaying this preview"
"popups-preview-footer-read": "Go to this page"
Bug: T183151
Change-Id: I0600dbc2e4d51a13675041d3c0741a793f4eae37
---
M i18n/en.json
M resources/ext.popups/styles/ext.popups.core.less
M tests/node-qunit/ui/renderer.test.js
3 files changed, 14 insertions(+), 11 deletions(-)
Approvals:
Jhernandez: Looks good to me, but someone else must approve
jenkins-bot: Verified
Jdlrobson: Looks good to me, approved
diff --git a/i18n/en.json b/i18n/en.json
index 08a3bb0..50d966f 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -18,8 +18,8 @@
"popups-settings-help": "You can turn previews back on using a link in
the footer of the page.",
"popups-settings-enable": "Enable previews",
"popups-send-feedback": "Send Feedback (external link)",
- "popups-preview-no-preview": "Looks like there isn't a preview for this
page",
- "popups-preview-footer-read": "Read",
+ "popups-preview-no-preview": "There was an issue displaying this
preview",
+ "popups-preview-footer-read": "Go to this page",
"prefs-reading": "Reading preferences",
"popups-prefs-optin-title": "Page previews\n\n<em>Get quick previews of
a topic while reading a page</em>",
"popups-prefs-optin-enabled-label": "Enable",
diff --git a/resources/ext.popups/styles/ext.popups.core.less
b/resources/ext.popups/styles/ext.popups.core.less
index 8ccfde5..9d4cc2a 100644
--- a/resources/ext.popups/styles/ext.popups.core.less
+++ b/resources/ext.popups/styles/ext.popups.core.less
@@ -217,8 +217,9 @@
font-size: 12px;
}
- // When the user dwells on the "Looks like there isn't..."
text, which is a
- // link to the page, then highlight the "Read" link too.
+ // When the user dwells on the "There was an issue displaying
this preview"
+ // text, which is a link to the page, then highlight the "Go to
this page"
+ // link too.
.mwe-popups-extract:hover + footer .mwe-popups-read-link {
text-decoration: underline;
}
diff --git a/tests/node-qunit/ui/renderer.test.js
b/tests/node-qunit/ui/renderer.test.js
index 590b300..2c8f98d 100644
--- a/tests/node-qunit/ui/renderer.test.js
+++ b/tests/node-qunit/ui/renderer.test.js
@@ -1,7 +1,9 @@
import * as renderer from '../../../src/ui/renderer';
import { createNullModel } from '../../../src/preview/model';
-var $ = jQuery;
+var $ = jQuery,
+ MSG_NO_PREVIEW = 'There was an issue displaying this preview',
+ MSG_GO_TO_PAGE = 'Go to this page';
/**
* A utility function that creates a bare bones preview
@@ -51,9 +53,9 @@
window.mediaWiki.msg = function ( key ) {
switch ( key ) {
case 'popups-preview-no-preview':
- return 'Looks like there isn\'t a
preview for this page';
+ return MSG_NO_PREVIEW;
case 'popups-preview-footer-read':
- return 'Read';
+ return MSG_GO_TO_PAGE;
}
};
@@ -171,8 +173,8 @@
assert.deepEqual(
this.renderSpy.getCall( 0 ).args[ 0 ],
$.extend( {}, model, {
- extractMsg: 'Looks like there isn\'t a preview for this
page',
- readMsg: 'Read'
+ extractMsg: MSG_NO_PREVIEW,
+ readMsg: MSG_GO_TO_PAGE
} ),
'Template is called with the correct data.'
);
@@ -199,8 +201,8 @@
assert.deepEqual(
this.renderSpy.getCall( 0 ).args[ 0 ],
$.extend( {}, model, {
- extractMsg: 'Looks like there isn\'t a preview for this
page',
- readMsg: 'Read'
+ extractMsg: MSG_NO_PREVIEW,
+ readMsg: MSG_GO_TO_PAGE
} ),
'Template is called with the correct data.'
);
--
To view, visit https://gerrit.wikimedia.org/r/403683
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0600dbc2e4d51a13675041d3c0741a793f4eae37
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Jhernandez <jhernan...@wikimedia.org>
Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: Pmiazga <pmia...@wikimedia.org>
Gerrit-Reviewer: Siebrand <siebr...@kitano.nl>
Gerrit-Reviewer: Sniedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
