Ema has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/404940 )
Change subject: cache_upload: use resp.reason in vtc test cases ...................................................................... cache_upload: use resp.reason in vtc test cases resp.msg has been renamed into resp.reason in varnish 5. Bug: T180433 Change-Id: Ib38a470dabc2a6ac5e48e240560804b1621b36a3 --- M modules/varnish/files/tests/upload/03-backend-if-cached.vtc M modules/varnish/files/tests/upload/09-frontend-homepage-commons-redirect.vtc 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Ema: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/varnish/files/tests/upload/03-backend-if-cached.vtc b/modules/varnish/files/tests/upload/03-backend-if-cached.vtc index 34c85c7..b63e0c9 100644 --- a/modules/varnish/files/tests/upload/03-backend-if-cached.vtc +++ b/modules/varnish/files/tests/upload/03-backend-if-cached.vtc @@ -18,7 +18,7 @@ txreq -url "/test" -hdr "Host: upload.wikimedia.org" -hdr "If-Cached: 15f0fff99ed5aae4edffdd6496d7131f" rxresp expect resp.status == 412 - expect resp.msg == "Entity not in cache" + expect resp.reason == "Entity not in cache" } -run client c2 { @@ -35,5 +35,5 @@ txreq -url "/test" -hdr "Host: upload.wikimedia.org" -hdr "If-Cached: mismatched-etag" rxresp expect resp.status == 412 - expect resp.msg == "Etag mismatch" + expect resp.reason == "Etag mismatch" } -run diff --git a/modules/varnish/files/tests/upload/09-frontend-homepage-commons-redirect.vtc b/modules/varnish/files/tests/upload/09-frontend-homepage-commons-redirect.vtc index 7c75527..bcfa975 100644 --- a/modules/varnish/files/tests/upload/09-frontend-homepage-commons-redirect.vtc +++ b/modules/varnish/files/tests/upload/09-frontend-homepage-commons-redirect.vtc @@ -18,7 +18,7 @@ rxresp expect resp.status == 301 - expect resp.msg == "Moved Permanently" + expect resp.reason == "Moved Permanently" expect resp.http.Location == "https://commons.wikimedia.org/" expect resp.http.Connection == "keep-alive" expect resp.http.Content-Length == 0 -- To view, visit https://gerrit.wikimedia.org/r/404940 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib38a470dabc2a6ac5e48e240560804b1621b36a3 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ema <e...@wikimedia.org> Gerrit-Reviewer: BBlack <bbl...@wikimedia.org> Gerrit-Reviewer: Ema <e...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits