jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/404902 )
Change subject: Fix: Crash if enters Randomizer page and leaves immediately
......................................................................
Fix: Crash if enters Randomizer page and leaves immediately
- If we leaves the Randomizer page before content summary being completely
loaded, the parent() will become null and cause a crash
- It can be reproduce easily if change language to zh-hant or zh-hans
Change-Id: I5347f226cd72f8feaca27708899959ce6c64a180
---
M app/src/main/java/org/wikipedia/random/RandomItemFragment.java
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/random/RandomItemFragment.java
b/app/src/main/java/org/wikipedia/random/RandomItemFragment.java
index 0efa0c2..254c16c 100644
--- a/app/src/main/java/org/wikipedia/random/RandomItemFragment.java
+++ b/app/src/main/java/org/wikipedia/random/RandomItemFragment.java
@@ -89,12 +89,11 @@
@Override
public void onSuccess(@NonNull Call<RbPageSummary> call, @NonNull
RbPageSummary pageSummary) {
loadComplete = true;
- parent().onChildLoaded();
-
if (!isAdded()) {
return;
}
setContents(pageSummary);
+ parent().onChildLoaded();
}
@Override
--
To view, visit https://gerrit.wikimedia.org/r/404902
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5347f226cd72f8feaca27708899959ce6c64a180
Gerrit-PatchSet: 3
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Cooltey <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Cooltey <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Sharvaniharan <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
