Ejegg has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/405005 )

Change subject: Fix extra params on method calls
......................................................................

Fix extra params on method calls

That nasty generated HTML should die in any case...

Change-Id: I2a82733fe554aafec1a2470309ad2aa19b647315
---
M gateway_common/GatewayPage.php
M globalcollect_gateway/orphan.adapter.php
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/05/405005/1

diff --git a/gateway_common/GatewayPage.php b/gateway_common/GatewayPage.php
index 30dcd1a..682a02a 100644
--- a/gateway_common/GatewayPage.php
+++ b/gateway_common/GatewayPage.php
@@ -276,7 +276,7 @@
                        $output->addHTML( Html::openElement( 'ul' ) );
                        foreach ( $data as $key => $value ) {
                                if ( is_array( $value ) ) {
-                                       $output->addHTML( Html::openElement( 
'li', null, $key ) . Html::openElement( 'ul' ) );
+                                       $output->addHTML( Html::openElement( 
'li', null ) . Html::openElement( 'ul' ) );
                                        foreach ( $value as $key2 => $val2 ) {
                                                $output->addHTML( 
Html::element( 'li', null, "$key2: $val2" ) );
                                        }
diff --git a/globalcollect_gateway/orphan.adapter.php 
b/globalcollect_gateway/orphan.adapter.php
index f61c75f..ebde7cf 100644
--- a/globalcollect_gateway/orphan.adapter.php
+++ b/globalcollect_gateway/orphan.adapter.php
@@ -42,7 +42,7 @@
                }
                if ( $final ) {
                        // FIXME
-                       $this->stageData( 'response' );
+                       $this->stageData();
                }
                foreach ( $unstaged as $key => $val ) {
                        $unstaged[$key] = $this->staged_data[$key];

-- 
To view, visit https://gerrit.wikimedia.org/r/405005
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a82733fe554aafec1a2470309ad2aa19b647315
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg <ej...@ejegg.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to