Jhernandez has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405018 )
Change subject: Remove unnecessary .promise() call ...................................................................... Remove unnecessary .promise() call In the mediawiki gateway fetch uses mw.Api which when calling ajax returns a promise (not a deferred). Thus .promise() here is unnecessary and happens to work because of jQuery promises but it is not a standard method on JS promises so it shouldn't be used on promises, only on deferreds. Change-Id: Iec609b90bffad8b99b3908897dfb72d7c4ed5481 --- M resources/dist/index.js M resources/dist/index.js.json M src/gateway/mediawiki.js 3 files changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups refs/changes/18/405018/1 -- To view, visit https://gerrit.wikimedia.org/r/405018 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iec609b90bffad8b99b3908897dfb72d7c4ed5481 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Jhernandez <jhernan...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
