jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/404769 )

Change subject: Add large test to verify featured-image results
......................................................................


Add large test to verify featured-image results

Change-Id: I34c68de0134a9975d6bfb34308c27bddb9c03837
---
A test/features/featured-image/featured-image-large.js
1 file changed, 59 insertions(+), 0 deletions(-)

Approvals:
  BearND: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/test/features/featured-image/featured-image-large.js 
b/test/features/featured-image/featured-image-large.js
new file mode 100644
index 0000000..1054c49
--- /dev/null
+++ b/test/features/featured-image/featured-image-large.js
@@ -0,0 +1,59 @@
+'use strict';
+
+const preq = require('preq');
+const assert = require('../../utils/assert.js');
+const server = require('../../utils/server.js');
+const testUtil = require('../../utils/testUtil.js');
+const dateUtil = require('../../../lib/dateUtil');
+
+const languages = ['en'];
+
+// Note: to run large tests set the env variable LARGE_TESTS to any string
+describe('featured-image-large', function() {
+
+    this.timeout(20000); // eslint-disable-line no-invalid-this
+
+    before(() => {
+        return server.start();
+    });
+
+    function uriForLang(dateString, lang = 'en') {
+        const baseUri = 
`${server.config.uri}${lang}.wikipedia.org/v1/media/image/featured`;
+        return `${baseUri}/${dateString}`;
+    }
+
+    function verify(res, lang, uri) {
+        assert.ok(res.status === 200);
+        assert.ok(res.body.title.length, `${uri} has no title`);
+        assert.ok(res.body.description, `${uri} has no description`);
+        assert.ok(res.body.description.text.length, `${uri} has no description 
text`);
+        assert.ok(res.body.description.lang.length, `${uri} has no description 
lang`);
+        assert.ok(res.body.thumbnail, `${uri} returns no thumbnail info`);
+        assert.ok(res.body.thumbnail.source.length, `${uri} has no thumbnail 
source URI`);
+        assert.ok(!isNaN(res.body.thumbnail.width), `${uri} thumbnail has 
invalid width`);
+        assert.ok(!isNaN(res.body.thumbnail.height), `${uri} thumbnail has 
invalid width`);
+        assert.ok(res.body.image, `${uri} returns no original image info`);
+        assert.ok(res.body.image.source.length, `${uri} has no original source 
URI`);
+        assert.ok(!isNaN(res.body.image.width), `${uri} original has invalid 
width`);
+        assert.ok(!isNaN(res.body.image.height), `${uri} original has invalid 
width`);
+    }
+
+    function fetchAndVerify(lang, dateString) {
+        const uri = uriForLang(dateString, lang);
+        return preq.get(uri).then(res => verify(res, lang, uri));
+    }
+
+    if (process.env.LARGE_TESTS) {
+        for (const lang of languages) {
+            for (const date = new Date(Date.UTC(2016, 0, 1));
+                date < dateUtil.addDays(new Date(), 30);
+                date.setUTCDate(date.getUTCDate() + 1)) {
+
+                const dateString = testUtil.constructTestDate(date);
+                it(`${lang}: ${dateString}`, () => {
+                    return fetchAndVerify(lang, dateString);
+                });
+            }
+        }
+    }
+});

-- 
To view, visit https://gerrit.wikimedia.org/r/404769
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I34c68de0134a9975d6bfb34308c27bddb9c03837
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Fjalapeno <cfl...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: Mhurd <mh...@wikimedia.org>
Gerrit-Reviewer: Ppchelko <ppche...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to