Hello Esanders, Legoktm, jenkins-bot, TheDJ,

I'd like you to do a code review.  Please visit

    https://gerrit.wikimedia.org/r/405031

to review the following change.


Change subject: Remove dummy isSupported function, deprecated in REL1_31
......................................................................

Remove dummy isSupported function, deprecated in REL1_31

This reverts commit a92c99cd45f3ffa1e606662d3e5a3fff170105dd.

Change-Id: I2567fbf5a41efb1242b690dd23e4b59b166c0251
---
M modules/jquery.wikiEditor.js
1 file changed, 0 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor 
refs/changes/31/405031/1

diff --git a/modules/jquery.wikiEditor.js b/modules/jquery.wikiEditor.js
index 691bcb3..5b098d8 100644
--- a/modules/jquery.wikiEditor.js
+++ b/modules/jquery.wikiEditor.js
@@ -61,20 +61,6 @@
                imgPath: mw.config.get( 'wgExtensionAssetsPath' ) + 
'/WikiEditor/modules/images/',
 
                /**
-                * Checks if the client supports WikiEditor.
-                *
-                * Since 1.31 this check is deprecated and can be skipped as 
all browsers
-                * which are served JS by MediaWiki support WikiEditor.
-                *
-                * @deprecated since 1.31
-                * @return {boolean}
-                */
-               isSupported: function () {
-                       mw.log.warn( '$.wikiEditor.isSupported is deprecated.' 
);
-                       return true;
-               },
-
-               /**
                 * Checks if a module has a specific requirement
                 *
                 * @param {Object} module Module object

-- 
To view, visit https://gerrit.wikimedia.org/r/405031
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2567fbf5a41efb1242b690dd23e4b59b166c0251
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to