Joal has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403890 )
Change subject: Update pageviews top and by-country response def
......................................................................
Update pageviews top and by-country response def
The top-endpoint used to send a string as a response (a json formatted
string, but a string nonetheless). When restbase-cassandra got a JSON
type, we updated the actual response but forgot to update the definition.
Here it is updated, in addition to the by-country one, that follows the
same logic.
Bug: T184541
Change-Id: I16183b2040cf89419f70600ce0609122da6846b4
---
M v1/pageviews.yaml
1 file changed, 22 insertions(+), 4 deletions(-)
Approvals:
Fdans: Verified; Looks good to me, approved
diff --git a/v1/pageviews.yaml b/v1/pageviews.yaml
index 44be4af..05139f7 100644
--- a/v1/pageviews.yaml
+++ b/v1/pageviews.yaml
@@ -440,8 +440,17 @@
day:
type: string
articles:
- # format for this is a json array: [{rank: 1, article:
<<title>>, views: 123}, ...]
- type: string
+ type: array
+ items:
+ properties:
+ rank:
+ type: integer
+ format: int32
+ article:
+ type: string
+ views:
+ type: integer
+ format: int64
by-country:
properties:
@@ -458,5 +467,14 @@
month:
type: string
countries:
- # format for this is a json array: [{rank: 1, country: <<name>>,
views: 123}, ...]
- type: string
+ type: array
+ items:
+ properties:
+ rank:
+ type: integer
+ format: int32
+ country:
+ type: string
+ views:
+ type: integer
+ format: int64
--
To view, visit https://gerrit.wikimedia.org/r/403890
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I16183b2040cf89419f70600ce0609122da6846b4
Gerrit-PatchSet: 1
Gerrit-Project: analytics/aqs
Gerrit-Branch: master
Gerrit-Owner: Joal <j...@wikimedia.org>
Gerrit-Reviewer: Fdans <fd...@wikimedia.org>
Gerrit-Reviewer: Joal <j...@wikimedia.org>
Gerrit-Reviewer: Milimetric <dandree...@wikimedia.org>
Gerrit-Reviewer: Nuria <nu...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
