jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403686 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: I579505bcc556d370e842133b3782366bc1876f9f
---
M .phpcs.xml
M AddThis.body.php
2 files changed, 11 insertions(+), 13 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.phpcs.xml b/.phpcs.xml
index 2c2a50d..21e0cec 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -1,13 +1,11 @@
<?xml version="1.0"?>
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
<exclude
name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc" />
- <arg name="encoding" value="utf8" />
- <exclude-pattern>vendor</exclude-pattern>
+ <arg name="encoding" value="UTF-8" />
</ruleset>
diff --git a/AddThis.body.php b/AddThis.body.php
index d39e4d8..c4d4667 100644
--- a/AddThis.body.php
+++ b/AddThis.body.php
@@ -13,7 +13,7 @@
/**
* Register parser hook
*
- * @param $parser Parser
+ * @param Parser &$parser
* @return bool
*/
public static function AddThisHeaderTag( &$parser ) {
@@ -25,7 +25,7 @@
/**
* Parser hook for the <addthis /> tag extension.
*
- * @param $parser
+ * @param Parser $parser
* @return string
*/
public static function parserHook( $parser ) {
@@ -59,9 +59,9 @@
/**
* Function for article header toolbar
*
- * @param $article Article
- * @param $outputDone
- * @param $pcache
+ * @param Article &$article
+ * @param bool &$outputDone
+ * @param bool &$pcache
* @return bool|bool
*/
public static function AddThisHeader( &$article, &$outputDone, &$pcache
) {
@@ -107,9 +107,9 @@
/**
* Function for sidebar portlet
*
- * @param $skin
- * @param $bar
- * @return bool|array|bool
+ * @param Skin $skin
+ * @param Sidebar &$bar
+ * @return bool|array
*/
public static function AddThisSidebar( $skin, &$bar ) {
global $wgOut, $wgAddThis, $wgAddThispubid, $wgAddThisSidebar,
$wgAddThisSBServ;
@@ -144,7 +144,7 @@
/**
* Converts an array definition of links into HTML tags
*
- * @param $links array
+ * @param array $links
* @return string
*/
protected static function makeLinks( $links ) {
--
To view, visit https://gerrit.wikimedia.org/r/403686
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I579505bcc556d370e842133b3782366bc1876f9f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/AddThis
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
