jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/403735 )

Change subject: Improve some parameter docs
......................................................................


Improve some parameter docs

Change-Id: Ia3af80241b82c2c09e9e4588873fdd54883ef48c
---
M .phpcs.xml
M ShowMe.hooks.php
2 files changed, 2 insertions(+), 5 deletions(-)

Approvals:
  Umherirrender: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/.phpcs.xml b/.phpcs.xml
index 93dbffe..d46c55a 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,14 +2,11 @@
 <ruleset>
        <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
                <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
-               <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
-               <exclude 
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
                <exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
                <exclude 
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
                <exclude name="Squiz.Scope.MethodScope.Missing" />
        </rule>
        <file>.</file>
        <arg name="extensions" value="php,php5,inc"/>
-       <arg name="encoding" value="utf8"/>
-       <exclude-pattern>vendor</exclude-pattern>
+       <arg name="encoding" value="UTF-8"/>
 </ruleset>
diff --git a/ShowMe.hooks.php b/ShowMe.hooks.php
index 4109ced..2a9ec48 100644
--- a/ShowMe.hooks.php
+++ b/ShowMe.hooks.php
@@ -10,7 +10,7 @@
 
        /**
         *
-        * @param Parser $parser
+        * @param Parser &$parser
         * @return bool
         */
        public static function onParserFirstCallInit( Parser &$parser ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/403735
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3af80241b82c2c09e9e4588873fdd54883ef48c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ShowMe
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to