jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403744 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: I8ee2396e6a804ab69965383a9ee6b30787c1f9af
---
M .phpcs.xml
M includes/CookieWarning.hooks.php
2 files changed, 10 insertions(+), 13 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.phpcs.xml b/.phpcs.xml
index 001deda..38b0041 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -3,12 +3,9 @@
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="Generic.Files.OneObjectStructurePerFile.MultipleFound" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
<exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc" />
- <arg name="encoding" value="utf8" />
- <exclude-pattern>vendor</exclude-pattern>
+ <arg name="encoding" value="UTF-8" />
</ruleset>
diff --git a/includes/CookieWarning.hooks.php b/includes/CookieWarning.hooks.php
index 22beb7e..d4d21c7 100644
--- a/includes/CookieWarning.hooks.php
+++ b/includes/CookieWarning.hooks.php
@@ -9,10 +9,10 @@
* If the disablecookiewarning POST data is send, disables the
cookiewarning bar with a
* cookie or a user preference, if the user is logged in.
*
- * @param Title $title
- * @param null $unused
- * @param OutputPage $output
- * @param User $user
+ * @param Title &$title
+ * @param null &$unused
+ * @param OutputPage &$output
+ * @param User &$user
* @param WebRequest $request
* @param MediaWiki $mediawiki
*/
@@ -36,8 +36,8 @@
*
* Adds the CookieWarning information bar to the output html.
*
- * @param SkinTemplate $sk
- * @param QuickTemplate $tpl
+ * @param SkinTemplate &$sk
+ * @param QuickTemplate &$tpl
*/
public static function onSkinTemplateOutputPageBeforeExec(
SkinTemplate &$sk, QuickTemplate &$tpl
@@ -157,7 +157,7 @@
/**
* ResourceLoaderGetConfigVars hook handler.
*
- * @param array $vars
+ * @param array &$vars
*/
public static function onResourceLoaderGetConfigVars( array &$vars ) {
$conf = self::getConfig();
@@ -186,7 +186,7 @@
* this page.
*
* @param IContextSource $context
- * @return boolean Returns true, if the cookie warning should be
visible, false otherwise.
+ * @return bool Returns true, if the cookie warning should be visible,
false otherwise.
*/
private static function showWarning( IContextSource $context ) {
$user = $context->getUser();
@@ -253,7 +253,7 @@
* @see https://www.mediawiki.org/wiki/Manual:Hooks/GetPreferences
*
* @param User $user
- * @param array $defaultPreferences
+ * @param array &$defaultPreferences
* @return bool
*/
public static function onGetPreferences( User $user,
&$defaultPreferences ) {
--
To view, visit https://gerrit.wikimedia.org/r/403744
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8ee2396e6a804ab69965383a9ee6b30787c1f9af
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CookieWarning
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
