jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/403714 )
Change subject: Improve some parameter docs
......................................................................
Improve some parameter docs
Change-Id: I7ef1922b8a3fffca7366e67fb481637bdc870509
---
M .phpcs.xml
M includes/Hooks.php
M includes/XenForoUser.php
3 files changed, 4 insertions(+), 8 deletions(-)
Approvals:
Umherirrender: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.phpcs.xml b/.phpcs.xml
index 336d3de..6cc1952 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -2,13 +2,9 @@
<ruleset>
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
- <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
</rule>
<file>.</file>
<arg name="extensions" value="php,php5,inc" />
- <arg name="encoding" value="utf8" />
- <exclude-pattern>vendor</exclude-pattern>
+ <arg name="encoding" value="UTF-8" />
</ruleset>
diff --git a/includes/Hooks.php b/includes/Hooks.php
index 29549f3..010ff3a 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -29,8 +29,8 @@
*
* @param array $requests
* @param array $fieldInfo
- * @param array $formDescriptor
- * @param $action
+ * @param array &$formDescriptor
+ * @param string $action
*/
public static function onAuthChangeFormFields( array $requests, array
$fieldInfo,
array &$formDescriptor, $action
diff --git a/includes/XenForoUser.php b/includes/XenForoUser.php
index dd2bace..29adb3c 100644
--- a/includes/XenForoUser.php
+++ b/includes/XenForoUser.php
@@ -111,7 +111,7 @@
/**
* Check, if the XenForo user ID is already connected to another wiki
account or not.
*
- * @param $id
+ * @param string $xfUserId
* @param int $flags
* @return bool
*/
--
To view, visit https://gerrit.wikimedia.org/r/403714
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ef1922b8a3fffca7366e67fb481637bdc870509
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/XenForoAuth
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
