jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/405732 )
Change subject: Mark all Lexeme API modules as "internal"
......................................................................
Mark all Lexeme API modules as "internal"
MediaWiki core does have an other idea of what "internal" means than
the team developing the Lexeme codebase does. For core, "internal" is
nothing but a message on the help page for the API module. This does not
hide the module in any way.
Change-Id: I29720dd35204384ee44dfa441e7b65d264bbdd62
---
M src/Api/AddForm.php
M src/Api/EditFormElements.php
2 files changed, 16 insertions(+), 0 deletions(-)
Approvals:
WMDE-leszek: Looks good to me, approved
Lucas Werkmeister (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/Api/AddForm.php b/src/Api/AddForm.php
index 0cec37a..4a84036 100644
--- a/src/Api/AddForm.php
+++ b/src/Api/AddForm.php
@@ -238,6 +238,14 @@
}
/**
+ * As long as this codebase is in development and APIs might change any
time without notice, we
+ * mark all as internal. This adds an "unstable" notice, but does not
hide them in any way.
+ */
+ public function isInternal() {
+ return true;
+ }
+
+ /**
* @see ApiBase::needsToken()
*/
public function needsToken() {
diff --git a/src/Api/EditFormElements.php b/src/Api/EditFormElements.php
index 5eb2068..7a9f1bd 100644
--- a/src/Api/EditFormElements.php
+++ b/src/Api/EditFormElements.php
@@ -196,6 +196,14 @@
}
/**
+ * As long as this codebase is in development and APIs might change any
time without notice, we
+ * mark all as internal. This adds an "unstable" notice, but does not
hide them in any way.
+ */
+ public function isInternal() {
+ return true;
+ }
+
+ /**
* @see ApiBase::needsToken()
*/
public function needsToken() {
--
To view, visit https://gerrit.wikimedia.org/r/405732
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I29720dd35204384ee44dfa441e7b65d264bbdd62
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Thiemo Kreuz (WMDE) <thiemo.kr...@wikimedia.de>
Gerrit-Reviewer: Ladsgroup <ladsgr...@gmail.com>
Gerrit-Reviewer: Lucas Werkmeister (WMDE) <lucas.werkmeis...@wikimedia.de>
Gerrit-Reviewer: WMDE-leszek <leszek.mani...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
