jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/405877 )
Change subject: Rewrite
ConstraintParameterRendererTest::assertConstraintReportParameterList
......................................................................
Rewrite ConstraintParameterRendererTest::assertConstraintReportParameterList
Instead of fiddling with $expected and constructing a pretty complex array
(and by doing so repeating parts of the implementation from
ConstraintParameterRenderer), I turn it around and rip $actual appart to
compare it.
This also fixes an actual mistake with an array key.
Bug: T169121
Change-Id: Ic8715c3338fe0b42314639519a524c1b50896e29
---
M tests/phpunit/ConstraintParameterRendererTest.php
1 file changed, 8 insertions(+), 6 deletions(-)
Approvals:
Lucas Werkmeister (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/ConstraintParameterRendererTest.php
b/tests/phpunit/ConstraintParameterRendererTest.php
index 14ce764..a5278bd 100644
--- a/tests/phpunit/ConstraintParameterRendererTest.php
+++ b/tests/phpunit/ConstraintParameterRendererTest.php
@@ -555,7 +555,7 @@
);
$this->assertConstraintReportParameterList(
- array_fill( 0, 10, 'statement' ) + [ 11 => '...' ],
+ array_fill( 0, 10, 'statement' ) + [ 10 => '...' ],
$formatted
);
}
@@ -565,11 +565,13 @@
* @param string $actual
*/
private function assertConstraintReportParameterList( array $expected,
$actual ) {
- $htmlList = '<ul>' . implode( '', array_map( function ( $item )
{
- return "<li>$item</li>";
- }, $expected ) ) . '</ul>';
- array_unshift( $expected, $htmlList );
- $this->assertSame( $expected, $actual );
+ $htmlList = '<ul>';
+ foreach ( $expected as $item ) {
+ $htmlList .= "<li>$item</li>";
+ }
+ $htmlList .= '</ul>';
+ $this->assertSame( $htmlList, $actual[0] );
+ $this->assertSame( $expected, array_slice( $actual, 1 ) );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/405877
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8715c3338fe0b42314639519a524c1b50896e29
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Thiemo Kreuz (WMDE) <thiemo.kr...@wikimedia.de>
Gerrit-Reviewer: Lucas Werkmeister (WMDE) <lucas.werkmeis...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
