Krinkle has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/405996 )
Change subject: cover: Add sort=cover parameter to coverage report
......................................................................
cover: Add sort=cover parameter to coverage report
When enabled, the sorting changes from alphabetical by name, to be
ascending by coverage percentage. This helps identify projects with
low code coverage, and as potential area to contribute.
Change-Id: I4ff4bb7191ad8579427cf74fd865fe23b85b234d
---
M shared/CoveragePage.php
1 file changed, 32 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/integration/docroot
refs/changes/96/405996/1
diff --git a/shared/CoveragePage.php b/shared/CoveragePage.php
index 9418a7e..389c7a6 100644
--- a/shared/CoveragePage.php
+++ b/shared/CoveragePage.php
@@ -47,6 +47,8 @@
$results = glob( $this->coverageDir . '/*/clover.xml' );
$this->embedCSS( file_get_contents( __DIR__ . '/cover.css' ) );
+ $sort = isset( $_GET['sort'] ) ? (string)$_GET['sort'] : null;
+
if ( $this->pageName === 'Test coverage' ) {
$href = $this->fixNavUrl( '/cover-extensions/' );
$breadcrumbs = <<<HTML
@@ -80,10 +82,39 @@
HTML;
$this->addHtmlContent( $intro );
+ if ( $sort === 'cov' ) {
+ $sortNav = <<<HTML
+<div class="btn-group">
+ <a class="btn btn-default" href="./">Sort by name</a>
+ <button type="button" class="btn btn-default active">Sort by
coverage percentage</button>
+</div>
+HTML;
+ } else {
+ $sortNav = <<<HTML
+<div class="btn-group">
+ <button type="button" class="btn btn-default active">Sort by
name</button>
+ <a class="btn btn-default" href="./?sort=cov">Sort by coverage
percentage</a>
+</div>
+HTML;
+ }
+
+ $this->addHtmlContent( $sortNav );
$this->addHtmlContent( '<ul class="nav nav-pills nav-stacked
cover-list">' );
$html = '';
+ $clovers = [];
foreach ( $results as $clover ) {
- $info = $this->parseClover( $clover );
+ $clovers[$clover] = $this->parseClover( $clover );
+ }
+ if ( isset( $_GET['sort'] ) && $_GET['sort'] === 'cov' ) {
+ // Order by coverage, ascending
+ uasort( $clovers, function ( $a, $b ) {
+ if ( $a['percent'] === $b['percent'] ) {
+ return 0;
+ }
+ return ( $a['percent'] < $b['percent'] ) ? -1 :
1;
+ } );
+ }
+ foreach ( $clovers as $clover => $info ) {
$dirName = htmlspecialchars( basename( dirname( $clover
) ) );
$percent = (string)round( $info['percent'] );
$color = $this->getLevelColor( $info['percent'] );
--
To view, visit https://gerrit.wikimedia.org/r/405996
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ff4bb7191ad8579427cf74fd865fe23b85b234d
Gerrit-PatchSet: 1
Gerrit-Project: integration/docroot
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
