Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/58627


Change subject: Revert "Don't set $wgResourceLoaderDebug"
......................................................................

Revert "Don't set $wgResourceLoaderDebug"

This reverts commit 3cb39f1dbbb9ac41efffae6631c22bc2abfa6892.
which breaks qunit tests

Change-Id: I3ce0fa834810db5447c0f4b704905fca072ddc4d
---
M includes/MobileFrontend.hooks.php
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/27/58627/1

diff --git a/includes/MobileFrontend.hooks.php 
b/includes/MobileFrontend.hooks.php
index 5a50fe3..bf31612 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -191,6 +191,10 @@
        public static function onResourceLoaderTestModules( array 
&$testModules, ResourceLoader &$resourceLoader ) {
                global $wgResourceModules, $wgResourceLoaderDebug;
 
+               // run RL in debug mode so that we get real line numbers on 
errors and
+               // so that sinon.js is loaded within global context
+               $wgResourceLoaderDebug = true;
+
                $testModuleBoilerplate = array(
                        'localBasePath' => dirname( __DIR__ ),
                        'remoteExtPath' => 'MobileFrontend',

-- 
To view, visit https://gerrit.wikimedia.org/r/58627
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ce0fa834810db5447c0f4b704905fca072ddc4d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to