Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/58884


Change subject: Remove usage of ValueFormatters Result interface
......................................................................

Remove usage of ValueFormatters Result interface

Change-Id: I2569e59465789892e83c2faa2587a488b2693c2f
---
M includes/SM_GeoCoordsValue.php
1 file changed, 1 insertion(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMaps 
refs/changes/84/58884/1

diff --git a/includes/SM_GeoCoordsValue.php b/includes/SM_GeoCoordsValue.php
index 7f47d80..91ba5b3 100644
--- a/includes/SM_GeoCoordsValue.php
+++ b/includes/SM_GeoCoordsValue.php
@@ -68,14 +68,7 @@
                        $dataItem->getAltitude()
                );
 
-               $formatterResult = $coordinateFormatter->format( $value );
-
-               if ( $formatterResult->isValid() ) {
-                       return $formatterResult->getValue();
-               }
-               else {
-                       return null;
-               }
+               return $coordinateFormatter->format( $value );
        }
        
        /**

-- 
To view, visit https://gerrit.wikimedia.org/r/58884
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2569e59465789892e83c2faa2587a488b2693c2f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMaps
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to