Tobias Gritschacher has submitted this change and it was merged.
Change subject: wikibase.ui.Toolbar: Fixed using incorrect scope reference
......................................................................
wikibase.ui.Toolbar: Fixed using incorrect scope reference
Change-Id: I7c0f3cfc75d6aefa64a6649ad3f86338b53ffaaa
---
M lib/resources/wikibase.ui.Toolbar.js
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Tobias Gritschacher: Verified; Looks good to me, approved
diff --git a/lib/resources/wikibase.ui.Toolbar.js
b/lib/resources/wikibase.ui.Toolbar.js
index baef7a0..2d9e263 100644
--- a/lib/resources/wikibase.ui.Toolbar.js
+++ b/lib/resources/wikibase.ui.Toolbar.js
@@ -307,7 +307,8 @@
* @see wb.utilities.ui.StatableObject.getState
*/
getState: function() {
- var state;
+ var self = this,
+ state;
$.each( this._items, function( i, item ) {
if( !item.isStateChangeable() ) {
return true; // ignore element if state is
locked at the moment
@@ -319,7 +320,7 @@
state = currentState;
} else {
// state of this element different from
others -> mixed state
- state = this.STATE.MIXED;
+ state = self.STATE.MIXED;
return false; // no point in checking
other states, we are mixed!
}
}
--
To view, visit https://gerrit.wikimedia.org/r/58698
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c0f3cfc75d6aefa64a6649ad3f86338b53ffaaa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
