Aaron Schulz has submitted this change and it was merged.

Change subject: Avoid use of __METHOD__ in closure.
......................................................................


Avoid use of __METHOD__ in closure.

Change-Id: Ib25063f41cc25647003442cbd5851c3b777b2a7a
---
M includes/User.php
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Demon: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/User.php b/includes/User.php
index e911cb0..cb5ad7a 100644
--- a/includes/User.php
+++ b/includes/User.php
@@ -1974,7 +1974,8 @@
                        $dbw = wfGetDB( DB_MASTER );
                        $userid = $this->mId;
                        $touched = $this->mTouched;
-                       $dbw->onTransactionIdle( function() use ( $dbw, 
$userid, $touched ) {
+                       $method = __METHOD__;
+                       $dbw->onTransactionIdle( function() use ( $dbw, 
$userid, $touched, $method ) {
                                // Prevent contention slams by checking 
user_touched first
                                $encTouched = $dbw->addQuotes( $dbw->timestamp( 
$touched ) );
                                $needsPurge = $dbw->selectField( 'user', '1',
@@ -1983,7 +1984,7 @@
                                        $dbw->update( 'user',
                                                array( 'user_touched' => 
$dbw->timestamp( $touched ) ),
                                                array( 'user_id' => $userid, 
'user_touched < ' . $encTouched ),
-                                               __METHOD__
+                                               $method
                                        );
                                }
                        } );

-- 
To view, visit https://gerrit.wikimedia.org/r/60307
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib25063f41cc25647003442cbd5851c3b777b2a7a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Demon <ch...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to