Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/60452
Change subject: Use RecentChange::getTitle in ExternalChangesLine
......................................................................
Use RecentChange::getTitle in ExternalChangesLine
Title::newFromText will use the given namespace as default, when parsing
a title with a namespace at the begin. This method will not use the
default, instead used the namespace from the given text.
dewiki used some categories with for example file: at the begin, which
have a wrong link in the watchlist/recentchanges. Fixed by using
RecentChanges::getTitle to get the correct title. Another solution is to
use Title::makeTitle direct.
bug:46886
Change-Id: I0a58cd4a8d98b94ccde1b70d25a4a3650a7d8c08
---
M client/includes/recentchanges/ExternalChangesLine.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/52/60452/1
diff --git a/client/includes/recentchanges/ExternalChangesLine.php
b/client/includes/recentchanges/ExternalChangesLine.php
index c2fa026..d135025 100644
--- a/client/includes/recentchanges/ExternalChangesLine.php
+++ b/client/includes/recentchanges/ExternalChangesLine.php
@@ -104,7 +104,7 @@
$line .= self::changeSeparator();
- $title = \Title::newFromText( $rc->getAttribute( 'rc_title' ),
$rc->getAttribute( 'rc_namespace' ) );
+ $title = $rc->getTitle();
$line .= \Linker::link( $title );
if ( in_array( $changeType, array( 'add', 'restore', 'update' )
) ) {
--
To view, visit https://gerrit.wikimedia.org/r/60452
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0a58cd4a8d98b94ccde1b70d25a4a3650a7d8c08
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
