Krinkle has submitted this change and it was merged.
Change subject: Parameter type hints
......................................................................
Parameter type hints
Replace spaces with tabs in i18n file
Change-Id: I43a71e89e5eb5713a1918f5dd708dba6e89b09ab
---
M HTMLTags.i18n.php
M HTMLTags_body.php
2 files changed, 15 insertions(+), 6 deletions(-)
Approvals:
Krinkle: Verified; Looks good to me, approved
diff --git a/HTMLTags.i18n.php b/HTMLTags.i18n.php
index eab7d0e..7b29af9 100644
--- a/HTMLTags.i18n.php
+++ b/HTMLTags.i18n.php
@@ -15,9 +15,9 @@
$messages = array();
$messages['en'] = array(
- 'htmltags-desc' => 'Allows for displaying HTML tags from a pre-specified
set',
- 'htmltags-notagname' => 'The attribute "tagname" must be set for this
tag.',
- 'htmltags-unsupportedtag' => 'The tag name "$1" is not supported for
<htmltag>.',
+ 'htmltags-desc' => 'Allows for displaying HTML tags from a
pre-specified set',
+ 'htmltags-notagname' => 'The attribute "tagname" must be set for this
tag.',
+ 'htmltags-unsupportedtag' => 'The tag name "$1" is not supported for
<htmltag>.',
);
/** Message documentation (Message documentation)
diff --git a/HTMLTags_body.php b/HTMLTags_body.php
index 82d8ff4..5f12437 100644
--- a/HTMLTags_body.php
+++ b/HTMLTags_body.php
@@ -8,6 +8,10 @@
class HTMLTags {
+ /**
+ * @param $parser Parser
+ * @return bool
+ */
public static function register( &$parser ) {
// Register the hook with the parser
$parser->setHook( 'htmltag', array( 'HTMLTags', 'render' ) );
@@ -17,6 +21,12 @@
/**
* Handle the <htmltag> tag.
+ *
+ * @param $input string
+ * @param $args array
+ * @param $parser Parser
+ * @param $frame PPFrame
+ * @return string
*/
public static function render( $input, $args, $parser, $frame ) {
global $wgHTMLTagsAttributes;
@@ -40,12 +50,11 @@
$value = $parser->replaceVariables( $value,
$frame );
$attributes[$key] = $value;
}
- }
+ }
// The use of Html::element() should prevent any attempt
// at JavaScript injection.
- $text = Html::element( $tagName, $attributes, $input );
- return $text;
+ return Html::element( $tagName, $attributes, $input );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/60598
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43a71e89e5eb5713a1918f5dd708dba6e89b09ab
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/HTMLTags
Gerrit-Branch: master
Gerrit-Owner: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org>
Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
