Dzahn has submitted this change and it was merged. Change subject: contint: 100% passing puppet-lint ......................................................................
contint: 100% passing puppet-lint I have added a few dummy class comments to make puppet-lint happy: BEFORE: $ cd modules/contint/ $ puppet-lint --with-filename . ./manifests/packages.pp - WARNING: class not documented on line 1 ./manifests/testswarm.pp - WARNING: class not documented on line 1 ./manifests/tmpfs.pp - WARNING: class not documented on line 1 $ AFTER: $ cd modules/contint/ $ puppet-lint --with-filename . $ \O/ Change-Id: I2de54b7badc93140055558f2130ff3109efcd49b --- M modules/contint/manifests/packages.pp M modules/contint/manifests/testswarm.pp M modules/contint/manifests/tmpfs.pp 3 files changed, 13 insertions(+), 0 deletions(-) Approvals: jenkins-bot: Verified Dzahn: Looks good to me, approved diff --git a/modules/contint/manifests/packages.pp b/modules/contint/manifests/packages.pp index daad6e9..3bdae07 100644 --- a/modules/contint/manifests/packages.pp +++ b/modules/contint/manifests/packages.pp @@ -1,3 +1,8 @@ +# +# Holds all the packages needed for continuous integration. +# +# FIXME: split this! +# class contint::packages { # Make sure we use ant version 1.8 or we will have a conflict diff --git a/modules/contint/manifests/testswarm.pp b/modules/contint/manifests/testswarm.pp index 8b94cde..1e007c5 100644 --- a/modules/contint/manifests/testswarm.pp +++ b/modules/contint/manifests/testswarm.pp @@ -1,3 +1,9 @@ +# Dummy class to keep the testswarm user on the contint box. +# +# Although we are not using testswarm as of April 2013, we might use it again. +# +# Upstream: https://github.com/jquery/testswarm +# class contint::testswarm { # Create a user to run the cronjob with diff --git a/modules/contint/manifests/tmpfs.pp b/modules/contint/manifests/tmpfs.pp index 3311ec1..b1fbde4 100644 --- a/modules/contint/manifests/tmpfs.pp +++ b/modules/contint/manifests/tmpfs.pp @@ -1,3 +1,5 @@ +# Wikimedia uses a small tmpfs disk to help soften I/O on the contint server. +# A typical use cases are the MediaWiki sqlite files class contint::tmpfs { include jenkins::user -- To view, visit https://gerrit.wikimedia.org/r/60851 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2de54b7badc93140055558f2130ff3109efcd49b Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Hashar <has...@free.fr> Gerrit-Reviewer: Dzahn <dz...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits