Matmarex has uploaded a new change for review.
https://gerrit.wikimedia.org/r/61075
Change subject: Remove all uses of obsolete .editsection class
......................................................................
Remove all uses of obsolete .editsection class
Cleanup after I6a6c12a9. To be merged after appropriate caches are purged.
Change-Id: I4950496e584735a3ceeb0e1c4123dfe6597f2ae1
---
M includes/resourceloader/ResourceLoaderUserCSSPrefsModule.php
M resources/mediawiki.action/mediawiki.action.view.rightClickEdit.js
M skins/cologneblue/screen.css
M skins/common/commonElements.css
M skins/common/commonPrint.css
M skins/common/oldshared.css
M skins/common/shared.css
M skins/common/wikiprintable.css
M skins/modern/main.css
M skins/modern/print.css
M skins/vector/screen.css
11 files changed, 6 insertions(+), 65 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/75/61075/1
diff --git a/includes/resourceloader/ResourceLoaderUserCSSPrefsModule.php
b/includes/resourceloader/ResourceLoaderUserCSSPrefsModule.php
index 61e6e15..7b4b668 100644
--- a/includes/resourceloader/ResourceLoaderUserCSSPrefsModule.php
+++ b/includes/resourceloader/ResourceLoaderUserCSSPrefsModule.php
@@ -81,7 +81,7 @@
$rules[] = "#toc { display: none; }\n";
}
if ( !$options['editsection'] ) {
- $rules[] = ".mw-editsection, .editsection { display:
none; }\n";
+ $rules[] = ".mw-editsection { display: none; }\n";
}
if ( $options['editfont'] !== 'default' ) {
// Double-check that $options['editfont'] consists of
safe characters only
diff --git a/resources/mediawiki.action/mediawiki.action.view.rightClickEdit.js
b/resources/mediawiki.action/mediawiki.action.view.rightClickEdit.js
index 0e85fd9..93befe3 100644
--- a/resources/mediawiki.action/mediawiki.action.view.rightClickEdit.js
+++ b/resources/mediawiki.action/mediawiki.action.view.rightClickEdit.js
@@ -5,10 +5,10 @@
*/
jQuery( function ( $ ) {
// Select all h1-h6 elements that contain editsection links
- // Don't use the ":has:(.editsection a)" selector because it performs
very bad.
+ // Don't use the ":has:(.mw-editsection a)" selector because it
performs very bad.
// http://jsperf.com/jq-1-7-2-vs-jq-1-8-1-performance-of-mw-has/2
$( document ).on( 'contextmenu', 'h1, h2, h3, h4, h5, h6', function ( e
) {
- var $edit = $( this ).find( '.mw-editsection a, .editsection a'
);
+ var $edit = $( this ).find( '.mw-editsection a' );
if ( !$edit.length ) {
return;
}
diff --git a/skins/cologneblue/screen.css b/skins/cologneblue/screen.css
index 349638a..9dbc4cb 100644
--- a/skins/cologneblue/screen.css
+++ b/skins/cologneblue/screen.css
@@ -135,10 +135,6 @@
line-height: 21pt;
}
-h1 .editsection {
- font-size: 55.6%;
-}
-
h1#firstHeading {
padding-bottom: 0;
margin-bottom: 0;
diff --git a/skins/common/commonElements.css b/skins/common/commonElements.css
index 2fa0cba..e564563 100644
--- a/skins/common/commonElements.css
+++ b/skins/common/commonElements.css
@@ -86,14 +86,8 @@
h1 {
font-size: 188%;
}
-h1 .editsection {
- font-size: 53%;
-}
h2 {
font-size: 150%;
-}
-h2 .editsection {
- font-size: 67%;
}
h3,
h4,
@@ -105,28 +99,14 @@
h3 {
font-size: 132%;
}
-h3 .editsection {
- font-size: 76%;
- font-weight: normal;
-}
h4 {
font-size: 116%;
}
-h4 .editsection {
- font-size: 86%;
- font-weight: normal; }
h5 {
font-size: 100%;
}
-h5 .editsection {
- font-weight: normal;
-}
h6 {
font-size: 80%;
-}
-h6 .editsection {
- font-size: 125%;
- font-weight: normal;
}
/* Some space under the headers in the content area */
diff --git a/skins/common/commonPrint.css b/skins/common/commonPrint.css
index 9b6d6ef..204b012 100644
--- a/skins/common/commonPrint.css
+++ b/skins/common/commonPrint.css
@@ -112,7 +112,6 @@
div#column-one,
#colophon,
.mw-editsection,
-.editsection,
.toctoggle,
.tochidden,
div#f-poweredbyico,
diff --git a/skins/common/oldshared.css b/skins/common/oldshared.css
index 6dcdf6f..25a067e 100644
--- a/skins/common/oldshared.css
+++ b/skins/common/oldshared.css
@@ -19,16 +19,6 @@
/* Now the custom parts */
-/* Make edit sections (which are inside h# tags) normal-sized */
-.editsection {
- font-weight: normal;
-}
-h1 .editsection { font-size: 50%; }
-h2 .editsection { font-size: 66.7%; }
-h3 .editsection { font-size: 85.5%; }
-h5 .editsection { font-size: 120%; }
-h6 .editsection { font-size: 133%; }
-
#footer { clear: both }
/* images */
/* @noflip */
@@ -458,4 +448,4 @@
display: block;
}
-/* RTL specific CSS ends here **/
\ No newline at end of file
+/* RTL specific CSS ends here **/
diff --git a/skins/common/shared.css b/skins/common/shared.css
index 13ff79d..cb299b8 100644
--- a/skins/common/shared.css
+++ b/skins/common/shared.css
@@ -127,21 +127,6 @@
cursor: pointer;
}
-/* Edit section links */
-/* Correct directionality when page dir is different from site/user dir */
-/* @noflip */
-.mw-content-ltr .editsection,
-.mw-content-rtl .mw-content-ltr .editsection {
- float: right;
- margin-left: 5px;
-}
-/* @noflip */
-.mw-content-rtl .editsection,
-.mw-content-ltr .mw-content-rtl .editsection {
- float: left;
- margin-right: 5px;
-}
-
/**
* File description page
*/
@@ -1092,7 +1077,8 @@
z-index: 99;
}
-.mw-editsection, .editsection, .toctoggle {
+.mw-editsection,
+.toctoggle {
-moz-user-select: none;
-webkit-user-select: none;
-ms-user-select: none;
diff --git a/skins/common/wikiprintable.css b/skins/common/wikiprintable.css
index f5650b5..dc236ea 100644
--- a/skins/common/wikiprintable.css
+++ b/skins/common/wikiprintable.css
@@ -33,7 +33,6 @@
#footer,
#siteNotice,
.mw-editsection,
-.editsection,
.toctoggle {
display: none;
}
diff --git a/skins/modern/main.css b/skins/modern/main.css
index f201209..29c0881 100644
--- a/skins/modern/main.css
+++ b/skins/modern/main.css
@@ -340,10 +340,6 @@
color: #a55858;
}
-span.editsection {
- font-size: small;
-}
-
h1, h2 {
border-bottom: solid 1px #003366;
}
diff --git a/skins/modern/print.css b/skins/modern/print.css
index 6e0f8b3..e97bbdb 100644
--- a/skins/modern/print.css
+++ b/skins/modern/print.css
@@ -4,7 +4,6 @@
#jump-to-nav,
#footer,
.mw-editsection,
-span.editsection,
.noprint {
display: none;
}
diff --git a/skins/vector/screen.css b/skins/vector/screen.css
index dc4267f..4c4bb30 100644
--- a/skins/vector/screen.css
+++ b/skins/vector/screen.css
@@ -688,10 +688,6 @@
font-size: 0.8em;
}
-.editsection {
- float: right;
-}
-
ul {
list-style-type: disc;
/* @embed */
--
To view, visit https://gerrit.wikimedia.org/r/61075
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4950496e584735a3ceeb0e1c4123dfe6597f2ae1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matmarex <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
