Daniel Werner has submitted this change and it was merged.
Change subject: Convert explicitly to float
......................................................................
Convert explicitly to float
Change-Id: I1af137d171fe6bd353eae64b8fa197e8dd901d8a
---
M ValueParsers/includes/parsers/DmsCoordinateParser.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Daniel Werner: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/ValueParsers/includes/parsers/DmsCoordinateParser.php
b/ValueParsers/includes/parsers/DmsCoordinateParser.php
index ba9f0ef..361ff3e 100644
--- a/ValueParsers/includes/parsers/DmsCoordinateParser.php
+++ b/ValueParsers/includes/parsers/DmsCoordinateParser.php
@@ -217,7 +217,7 @@
}
$degreePosition = strpos( $coordinate, $this->getOption(
self::OPT_DEGREE_SYMBOL ) );
- $degrees = substr( $coordinate, 0, $degreePosition );
+ $degrees = (float)substr( $coordinate, 0, $degreePosition );
$minutePosition = strpos( $coordinate, $this->getOption(
self::OPT_MINUTE_SYMBOL ) );
--
To view, visit https://gerrit.wikimedia.org/r/59077
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1af137d171fe6bd353eae64b8fa197e8dd901d8a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de>
Gerrit-Reviewer: John Erling Blad <jeb...@gmail.com>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
