Mwalker has uploaded a new change for review. https://gerrit.wikimedia.org/r/62631
Change subject: HTMLTextAreaField: Allow sizes to be overridden by child classes ...................................................................... HTMLTextAreaField: Allow sizes to be overridden by child classes Change-Id: I51e8bcba95c7b555f072329b01c6577115f246b3 --- M includes/HTMLForm.php 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/31/62631/1 diff --git a/includes/HTMLForm.php b/includes/HTMLForm.php index 0cda0dc..5e3bb06 100644 --- a/includes/HTMLForm.php +++ b/includes/HTMLForm.php @@ -1657,16 +1657,19 @@ } } class HTMLTextAreaField extends HTMLFormField { + const DEFAULT_COLS = 80; + const DEFAULT_ROWS = 25; + function getCols() { return isset( $this->mParams['cols'] ) ? $this->mParams['cols'] - : 80; + : static::DEFAULT_COLS; } function getRows() { return isset( $this->mParams['rows'] ) ? $this->mParams['rows'] - : 25; + : static::DEFAULT_ROWS; } function getInputHTML( $value ) { -- To view, visit https://gerrit.wikimedia.org/r/62631 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I51e8bcba95c7b555f072329b01c6577115f246b3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.22wmf3 Gerrit-Owner: Mwalker <mwal...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits