jenkins-bot has submitted this change and it was merged. Change subject: (bug 41619) Converting hard coded strings in diff view to i18n values ......................................................................
(bug 41619) Converting hard coded strings in diff view to i18n values Change-Id: Ib9b80518433fae24282f3006c00bed257291a47e --- M lib/WikibaseLib.i18n.php M lib/includes/EntityDiffVisualizer.php 2 files changed, 12 insertions(+), 4 deletions(-) Approvals: Aude: Checked; Looks good to me, approved jenkins-bot: Verified diff --git a/lib/WikibaseLib.i18n.php b/lib/WikibaseLib.i18n.php index 060d1d5..6f2e3fe 100644 --- a/lib/WikibaseLib.i18n.php +++ b/lib/WikibaseLib.i18n.php @@ -24,6 +24,10 @@ 'wikibase-diffview-reference' => 'reference', 'wikibase-diffview-rank' => 'rank', 'wikibase-diffview-qualifier' => 'qualifier', + 'wikibase-diffview-label' => 'label', + 'wikibase-diffview-alias' => 'aliases', + 'wikibase-diffview-description' => 'description', + 'wikibase-diffview-link' => 'links', 'wikibase-error-unexpected' => 'An unexpected error occurred.', 'wikibase-error-save-generic' => 'An error occurred while trying to perform save and because of this, your changes could not be completed.', 'wikibase-error-remove-generic' => 'An error occurred while trying to perform remove and because of this, your changes could not be completed.', @@ -104,6 +108,10 @@ {{Identical|Item}}', 'datatypes-type-commonsMedia' => 'The name of a data type for media files on Wikimedia Commons (proper name, capitalised in English; first letter capitalised anyway in this message and relatives).', 'version-wikibase' => 'Name of the Wikibase extension collection, used on [[Special:Version]]', + 'wikibase-diffview-label' => 'Sub heading for label changes in a diff', + 'wikibase-diffview-alias' => 'Sub heading for alias changes in a diff', + 'wikibase-diffview-description' => 'Sub heading for description changes in a diff', + 'wikibase-diffview-link' => 'Sub heading for link changes in a diff', ); /** Afrikaans (Afrikaans) diff --git a/lib/includes/EntityDiffVisualizer.php b/lib/includes/EntityDiffVisualizer.php index dcf6538..7195839 100644 --- a/lib/includes/EntityDiffVisualizer.php +++ b/lib/includes/EntityDiffVisualizer.php @@ -92,9 +92,9 @@ $termDiffVisualizer = new DiffView( array(), new Diff( array( - 'label' => $diff->getLabelsDiff(), - 'aliases' => $diff->getAliasesDiff(), - 'description' => $diff->getDescriptionsDiff(), + $this->context->getLanguage()->getMessage( 'wikibase-diffview-label' ) => $diff->getLabelsDiff(), + $this->context->getLanguage()->getMessage( 'wikibase-diffview-alias' ) => $diff->getAliasesDiff(), + $this->context->getLanguage()->getMessage( 'wikibase-diffview-description' ) => $diff->getDescriptionsDiff(), ), true ), $this->context ); @@ -110,7 +110,7 @@ $termDiffVisualizer = new DiffView( array(), new Diff( array( - 'links' => $diff->getSiteLinkDiff(), + $this->context->getLanguage()->getMessage( 'wikibase-diffview-link' ) => $diff->getSiteLinkDiff(), ), true ), $this->context ); -- To view, visit https://gerrit.wikimedia.org/r/62731 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9b80518433fae24282f3006c00bed257291a47e Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de> Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits