Daniel Kinzler has uploaded a new change for review.
https://gerrit.wikimedia.org/r/64274
Change subject: Don't use flus(), it interferes with output buffers
......................................................................
Don't use flus(), it interferes with output buffers
Change-Id: I4262bebf04c90e9c2ee0d31cba2a9c83fc6b870b
---
M repo/includes/specials/SpecialEntityData.php
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/74/64274/1
diff --git a/repo/includes/specials/SpecialEntityData.php
b/repo/includes/specials/SpecialEntityData.php
index fa0a084..7373bb6 100755
--- a/repo/includes/specials/SpecialEntityData.php
+++ b/repo/includes/specials/SpecialEntityData.php
@@ -445,12 +445,11 @@
$response->header( 'Cache-Control: ' . $mode . ', s-maxage=' .
$smaxage . ', max-age=' . $maxage );
$this->getOutput()->disable(); // don't generate HTML
- ob_clean();
+ ob_clean(); // remove anything that might already be in the
output buffer.
print $data;
- flush();
- //die(); //FIXME: figure out how to best shut down here.
+ // exit normally here, keeping all levels of output buffering.
}
}
--
To view, visit https://gerrit.wikimedia.org/r/64274
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4262bebf04c90e9c2ee0d31cba2a9c83fc6b870b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
