jenkins-bot has submitted this change and it was merged.
Change subject: Cog icon can be used to close the language settings panel
......................................................................
Cog icon can be used to close the language settings panel
Bug: 47971
Change-Id: I7b6d6142e113bf3f90feef1650bc384a5edc42cb
---
M resources/js/ext.uls.languagesettings.js
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Amire80: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/js/ext.uls.languagesettings.js
b/resources/js/ext.uls.languagesettings.js
index 7aced3f..6e17954 100644
--- a/resources/js/ext.uls.languagesettings.js
+++ b/resources/js/ext.uls.languagesettings.js
@@ -65,7 +65,7 @@
listen: function () {
var langSettings = this;
// Register all event listeners to the ULS language
settings here.
- langSettings.$element.on( 'click', $.proxy(
langSettings.show, langSettings ) );
+ langSettings.$element.on( 'click', $.proxy(
langSettings.click, langSettings ) );
langSettings.$window.find( '#languagesettings-close' )
.on( 'click', $.proxy( langSettings.close,
langSettings ) );
@@ -219,7 +219,9 @@
},
click: function () {
- if ( !this.shown ) {
+ if ( this.shown ) {
+ this.hide();
+ } else {
this.show();
}
}
--
To view, visit https://gerrit.wikimedia.org/r/64256
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b6d6142e113bf3f90feef1650bc384a5edc42cb
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>
Gerrit-Reviewer: Amire80 <amir.ahar...@mail.huji.ac.il>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
