Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/64801
Change subject: Re-fix pixel grid snapping on new text style icons
......................................................................
Re-fix pixel grid snapping on new text style icons
Trevor tweaked the pixel grid snapping on my previous commit
but it appears that introduced some errors as well. The horizontal
lines in underline-a and strikethrough-s no longer have integer
x-coordinates, and on underline-u the whole object is offset
by (0.166, 0.166).
Bug: 47780
Change-Id: I51f2605e7d8e2bab1d641f02244d5cd24f505676
---
M modules/ve/ui/styles/images/icons/strikethrough-s.png
M modules/ve/ui/styles/images/icons/strikethrough-s.svg
M modules/ve/ui/styles/images/icons/underline-a.png
M modules/ve/ui/styles/images/icons/underline-a.svg
M modules/ve/ui/styles/images/icons/underline-u.png
M modules/ve/ui/styles/images/icons/underline-u.svg
6 files changed, 5 insertions(+), 15 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/01/64801/1
diff --git a/modules/ve/ui/styles/images/icons/strikethrough-s.png
b/modules/ve/ui/styles/images/icons/strikethrough-s.png
index b899bba..28c721c 100644
--- a/modules/ve/ui/styles/images/icons/strikethrough-s.png
+++ b/modules/ve/ui/styles/images/icons/strikethrough-s.png
Binary files differ
diff --git a/modules/ve/ui/styles/images/icons/strikethrough-s.svg
b/modules/ve/ui/styles/images/icons/strikethrough-s.svg
index db3b978..539bf19 100644
--- a/modules/ve/ui/styles/images/icons/strikethrough-s.svg
+++ b/modules/ve/ui/styles/images/icons/strikethrough-s.svg
@@ -5,16 +5,8 @@
height="24px" viewBox="0 0 24 24" style="enable-background:new 0 0 24
24;" xml:space="preserve">
<g id="Icons" style="opacity:0.75;">
<g id="strikethrough-s">
- <path id="strikethrough" d="M5.333,12h12v1h-12V12z"/>
- <path id="s"
d="M11.427,6c-1.133,0-2.076,0.287-2.75,0.9c-0.67,0.613-1,1.49-1,2.52c0,0.889,0.221,1.602,0.719,2.13
-
s1.279,0.91,2.312,1.14l0.812,0.181v-0.03c0.656,0.147,1.129,0.375,1.375,0.63c0.252,0.256,0.375,0.607,0.375,1.11
-
c0,0.573-0.172,0.97-0.531,1.26c-0.359,0.291-0.895,0.45-1.625,0.45c-0.477,0-0.969-0.074-1.469-0.24
-
c-0.502-0.166-1.031-0.417-1.562-0.75l-0.375-0.239v0.449v1.53v0.18l0.156,0.061c0.58,0.237,1.143,0.417,1.688,0.54
-
c0.549,0.122,1.07,0.18,1.562,0.18c1.286,0,2.297-0.293,3-0.9c0.708-0.606,1.062-1.487,1.062-2.609
-
c0-0.943-0.256-1.725-0.781-2.311c-0.521-0.592-1.305-1-2.344-1.229l-0.812-0.181c-0.716-0.148-1.204-0.352-1.406-0.539
-
C9.628,10.032,9.521,9.75,9.521,9.3c0-0.533,0.162-0.899,0.5-1.17c0.342-0.271,0.836-0.42,1.531-0.42
-
c0.395,0,0.818,0.052,1.25,0.181c0.433,0.127,0.908,0.333,1.406,0.6l0.375,0.18V6.63c0,0-1.188-0.383-1.688-0.479
- C12.396,6.053,11.911,6,11.427,6z"/>
+ <path id="strikethrough" d="m 6,12 12,0 0,1 -12,0 z" />
+ <path id="s" d="m 12.09375,6 c -1.132956,1.17e-5
-2.07551,0.2867306 -2.75,0.9 -0.669495,0.6131262 -1,1.4900329 -1,2.52
-10e-7,0.888455 0.220748,1.601459 0.71875,2.13 0.497653,0.528189
1.278913,0.910203 2.3125,1.14 l 0.8125,0.18 0,-0.03 c 0.655604,0.14737
1.128367,0.375165 1.375,0.63 0.251303,0.255859 0.374994,0.607135 0.375,1.11
-6e-6,0.573405 -0.172082,0.969872 -0.53125,1.26 -0.359575,0.29045
-0.894947,0.45 -1.625,0.45 -0.476429,1e-6 -0.968273,-0.07424 -1.46875,-0.24 C
9.811117,15.883943 9.281704,15.633061 8.75,15.3 l -0.375,-0.24 0,0.45 0,1.53
0,0.18 0.15625,0.06 c 0.579946,0.237784 1.143189,0.417421 1.6875,0.54
0.548644,0.122522 1.069888,0.18 1.5625,0.18 1.286329,-2e-6 2.29644,-0.29319
3,-0.9 0.708111,-0.606563 1.062491,-1.487831 1.0625,-2.61 -9e-6,-0.943171
-0.256459,-1.723992 -0.78125,-2.31 -0.520612,-0.592177 -1.304882,-1
-2.34375,-1.23 l -0.8125,-0.18 C 11.190312,10.620716 10.702216,10.418172
10.5,10.23 10.295065,10.032202 10.187497,9.749864 10.1875,9.3 c
-3e-6,-0.5331626 0.162815,-0.8992468 0.5,-1.17 0.341797,-0.2713953
0.836206,-0.42 1.53125,-0.42 0.394271,9.4e-6 0.817951,0.052308 1.25,0.18
0.432526,0.1278557 0.907868,0.3338592 1.40625,0.6 l 0.375,0.18 0,-2.04 c 0,0
-1.188351,-0.3828324 -1.6875,-0.48 C 13.063194,6.052828 12.577504,6 12.09375,6
z" />
</g>
</g>
<g id="Guides">
diff --git a/modules/ve/ui/styles/images/icons/underline-a.png
b/modules/ve/ui/styles/images/icons/underline-a.png
index e710db3..6682267 100644
--- a/modules/ve/ui/styles/images/icons/underline-a.png
+++ b/modules/ve/ui/styles/images/icons/underline-a.png
Binary files differ
diff --git a/modules/ve/ui/styles/images/icons/underline-a.svg
b/modules/ve/ui/styles/images/icons/underline-a.svg
index 287ae77..eefc01e 100644
--- a/modules/ve/ui/styles/images/icons/underline-a.svg
+++ b/modules/ve/ui/styles/images/icons/underline-a.svg
@@ -7,7 +7,7 @@
<g id="underline-a">
<path id="a"
d="M13.925,16h2.076L12.538,6h-2.077l-3.46,10h2.077l0.627-2h3.604L13.925,16z
M10.004,12.377L11.5,7.998l1.51,4.379
h-3H10.004z"/>
- <path id="underline" d="M6.501,17h10v1h-10V17z"/>
+ <path id="underline" d="M6,17h11v1h-11V17z"/>
</g>
</g>
<g id="Guides">
diff --git a/modules/ve/ui/styles/images/icons/underline-u.png
b/modules/ve/ui/styles/images/icons/underline-u.png
index 979953c..a10b438 100644
--- a/modules/ve/ui/styles/images/icons/underline-u.png
+++ b/modules/ve/ui/styles/images/icons/underline-u.png
Binary files differ
diff --git a/modules/ve/ui/styles/images/icons/underline-u.svg
b/modules/ve/ui/styles/images/icons/underline-u.svg
index 9413ac8..1ea61f6 100644
--- a/modules/ve/ui/styles/images/icons/underline-u.svg
+++ b/modules/ve/ui/styles/images/icons/underline-u.svg
@@ -5,10 +5,8 @@
height="24px" viewBox="0 0 24 24" style="enable-background:new 0 0 24
24;" xml:space="preserve">
<g id="Icons" style="opacity:0.75;">
<g id="underline-u">
- <path id="u"
d="M8.166,6.166h2v5.959c-0.104,1.707,0.695,2.002,2,2.041c1.777,0.063,2.002-0.879,2-2.041V6.166h2v6.123
-
c0,1.279-0.338,2.245-1.015,2.898c-0.673,0.652-1.666,0.979-2.981,0.979c-1.32,0-2.319-0.326-2.996-0.979
- c-0.672-0.653-1.008-1.619-1.008-2.898V6.166"/>
- <path id="underline_1_" d="M7.166,17.166h10v1h-10V17.166z"/>
+ <path id="underline" d="m 7,17 10,0 0,1 -10,0 z" />
+ <path id="u" d="M 8,6 10,6 10,11.959264 C 9.8968337,13.665987
10.69484,13.960762 12,14 c 1.777065,0.06362 2.002451,-0.878656 2,-2.040736 L
14,6 l 2.000001,8e-7 0,6.1235212 c -9e-6,1.279022 -0.3383,2.244854
-1.014873,2.897504 -0.671924,0.652649 -1.665799,0.978975 -2.981628,0.978975
-1.320505,0 -2.3190462,-0.326326 -2.9956254,-0.978975 C 8.335957,14.368376 8
,13.402544 8,12.123522 l 0,-6.1235212" />
</g>
</g>
<g id="Guides">
--
To view, visit https://gerrit.wikimedia.org/r/64801
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51f2605e7d8e2bab1d641f02244d5cd24f505676
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
