Tobias Gritschacher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/65659
Change subject: Triggering "animationstep" event in snakview value variation
......................................................................
Triggering "animationstep" event in snakview value variation
Bug 48677
Change-Id: Ie6717ccece619b7cb8a096f016a690cda3b9ed80
---
M
lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js
1 file changed, 17 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/59/65659/1
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js
index facf8c2..c4e3af8 100644
---
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js
+++
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js
@@ -4,6 +4,12 @@
*
* @licence GNU GPL v2+
* @author Daniel Werner < daniel.wer...@wikimedia.de >
+ *
+ * @event animationstep: Triggered on the html element while the variation's
viewport is being
+ * animated.
+ * (1) {jQuery.Event}
+ * (2) {Number} now
+ * (3) {jQuery.Tween} tween
*/
( function( mw, wb, dv, dt, $ ) {
'use strict';
@@ -175,7 +181,7 @@
},
/**
- * Attach event handlers to the value view widget's element.
+ * Attaches event handlers to the value view widget's element.
*/
_attachEventHandlers: function() {
var self = this;
@@ -209,11 +215,19 @@
var currentHeight =
self.$viewPort.height();
self.$viewPort.css( 'height', 'auto' );
newHeight = self.$viewPort.height();
- self.$viewPort.height( currentHeight )
+ self.$viewPort.height( currentHeight );
}
if( tween === undefined ) {
- self.$viewPort.animate( { height:
newHeight }, 250 );
+ self.$viewPort.animate(
+ { height: newHeight },
+ {
+ duration: 250,
+ step: function( now,
tween ) {
+ $( 'html'
).trigger( 'animationstep', [ now, tween ] );
+ }
+ }
+ );
} else {
self.$viewPort.height( newHeight );
}
--
To view, visit https://gerrit.wikimedia.org/r/65659
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6717ccece619b7cb8a096f016a690cda3b9ed80
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.22-wmf5
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
