Tobias Gritschacher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/65663
Change subject: Always resize StringValue expert input element
......................................................................
Always resize StringValue expert input element
(Bug 48747)
String expert needs to be resized even when there is no valid value (e.g. to
reset
the input box height to one line if there is no value).
Change-Id: Ic5dadea3241d6731f28e4c6ad36a3049b2587a61
---
M ValueView/resources/jquery.valueview/valueview.experts/experts.StringValue.js
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues
refs/changes/63/65663/1
diff --git
a/ValueView/resources/jquery.valueview/valueview.experts/experts.StringValue.js
b/ValueView/resources/jquery.valueview/valueview.experts/experts.StringValue.js
index 1e9e9da..39d1eea 100644
---
a/ValueView/resources/jquery.valueview/valueview.experts/experts.StringValue.js
+++
b/ValueView/resources/jquery.valueview/valueview.experts/experts.StringValue.js
@@ -96,11 +96,13 @@
var textValue = this._newValue === null ? '' :
this._newValue;
this._newValue = false;
- // Display value and resize textarea to fit for
the value:
+ // Display value:
this.$input.val( textValue );
- this._resizeInput();
}
+ // Resize textarea to fit the value (which might be
empty):
+ this._resizeInput();
+
// We always use the textare for displaying the value,
only in edit mode we format the
// textare as an input field though.
if( this._viewState.isInEditMode() ) {
--
To view, visit https://gerrit.wikimedia.org/r/65663
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic5dadea3241d6731f28e4c6ad36a3049b2587a61
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: mw1.22-wmf5
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
