jenkins-bot has submitted this change and it was merged. Change subject: Added tests for PropertyValueSortExpression ......................................................................
Added tests for PropertyValueSortExpression Change-Id: Id4e89324f2c8852b6e2810b7bac3de2e272fa936 --- M Tests/Phpunit/Language/Option/PropertyValueSortExpressionTest.php 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Tobias Gritschacher: Looks good to me, approved jenkins-bot: Verified diff --git a/Tests/Phpunit/Language/Option/PropertyValueSortExpressionTest.php b/Tests/Phpunit/Language/Option/PropertyValueSortExpressionTest.php index b2c559d..71b1ba3 100644 --- a/Tests/Phpunit/Language/Option/PropertyValueSortExpressionTest.php +++ b/Tests/Phpunit/Language/Option/PropertyValueSortExpressionTest.php @@ -37,6 +37,26 @@ */ class PropertyValueSortExpressionTest extends SortExpressionTest { + public function testCanConstruct() { + new PropertyValueSortExpression( + new StringValue( 'foo' ), + SortExpression::ASCENDING + ); + + $this->assertTrue( true ); + } + + public function testGetPropertyId() { + $propertyId = new StringValue( 'foo' ); + + $sortExpression = new PropertyValueSortExpression( + $propertyId, + SortExpression::ASCENDING + ); + + $this->assertEquals( $propertyId, $sortExpression->getPropertyId() ); + } + /** * @see SortExpressionTest::getInstances * -- To view, visit https://gerrit.wikimedia.org/r/65293 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4e89324f2c8852b6e2810b7bac3de2e272fa936 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Ask Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: Anja Jentzsch <a...@anjeve.de> Gerrit-Reviewer: Ataherivand <abraham.taheriv...@wikimedia.de> Gerrit-Reviewer: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de> Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: Denny Vrandecic <denny.vrande...@wikimedia.de> Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de> Gerrit-Reviewer: Jens Ohlig <jens.oh...@wikimedia.de> Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: John Erling Blad <jeb...@gmail.com> Gerrit-Reviewer: Lydia Pintscher <lydia.pintsc...@wikimedia.de> Gerrit-Reviewer: Markus Kroetzsch <mar...@semantic-mediawiki.org> Gerrit-Reviewer: Nikola Smolenski <smole...@eunet.rs> Gerrit-Reviewer: Silke Meyer <silke.me...@wikimedia.de> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits