Denny Vrandecic has submitted this change and it was merged.
Change subject: Removed impossible to test else case, only there for legacy
reasons, from Diff
......................................................................
Removed impossible to test else case, only there for legacy reasons, from Diff
Change-Id: I3ef31699c9bcce5a6597be207c0221837d8f9fde
---
M includes/diffop/diff/Diff.php
1 file changed, 1 insertion(+), 5 deletions(-)
Approvals:
Denny Vrandecic: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/diffop/diff/Diff.php b/includes/diffop/diff/Diff.php
index ac0c306..237f2a1 100644
--- a/includes/diffop/diff/Diff.php
+++ b/includes/diffop/diff/Diff.php
@@ -24,7 +24,7 @@
*
* @var boolean|null
*/
- protected $isAssociative;
+ protected $isAssociative = null;
/**
* Pointers to the operations of certain types for quick lookup.
@@ -192,10 +192,6 @@
elseif ( $this instanceof ListDiff ) {
$this->isAssociative = false;
}
- else {
- $this->isAssociative = null;
- }
-
return $serializationData;
}
--
To view, visit https://gerrit.wikimedia.org/r/65698
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ef31699c9bcce5a6597be207c0221837d8f9fde
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Diff
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Denny Vrandecic <denny.vrande...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
