Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65801


Change subject: Added @throws docs
......................................................................

Added @throws docs

Change-Id: I47c7ad264501c884be28566167fd4dd17e6f03de
---
M includes/patcher/ListPatcher.php
M includes/patcher/MapPatcher.php
M includes/patcher/ThrowingPatcher.php
3 files changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Diff 
refs/changes/01/65801/1

diff --git a/includes/patcher/ListPatcher.php b/includes/patcher/ListPatcher.php
index b005d0a..3525e57 100644
--- a/includes/patcher/ListPatcher.php
+++ b/includes/patcher/ListPatcher.php
@@ -43,6 +43,7 @@
         * @param Diff $diff
         *
         * @return array
+        * @throws PatcherException
         */
        public function patch( array $base, Diff $diff ) {
                if ( $this->throwErrors && $diff->looksAssociative() ) {
diff --git a/includes/patcher/MapPatcher.php b/includes/patcher/MapPatcher.php
index fc6e82a..9354107 100644
--- a/includes/patcher/MapPatcher.php
+++ b/includes/patcher/MapPatcher.php
@@ -4,7 +4,6 @@
 
 use Diff\Comparer\StrictComparer;
 use Diff\Comparer\ValueComparer;
-use RuntimeException;
 
 /**
  * Map patcher.
@@ -80,7 +79,7 @@
         * @param Diff $diff
         *
         * @return array
-        * @throws RuntimeException
+        * @throws PatcherException
         */
        public function patch( array $base, Diff $diff ) {
                /**
diff --git a/includes/patcher/ThrowingPatcher.php 
b/includes/patcher/ThrowingPatcher.php
index da0eb7a..658723e 100644
--- a/includes/patcher/ThrowingPatcher.php
+++ b/includes/patcher/ThrowingPatcher.php
@@ -88,6 +88,7 @@
         * @param Diff $diff
         *
         * @return Diff
+        * @throws PatcherException
         */
        public function getApplicableDiff( array $base, Diff $diff ) {
                $throwErrors = $this->throwErrors;

-- 
To view, visit https://gerrit.wikimedia.org/r/65801
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I47c7ad264501c884be28566167fd4dd17e6f03de
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Diff
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to